Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate systemd unit files #10597

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Validate systemd unit files #10597

merged 2 commits into from
Nov 17, 2023

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Nov 6, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This ensure that we fail early if we have a bad systemd unit file
(syntax error, using a version not available in the local version, etc)

For example it will catch error like the one fixed by #10596

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Validate systemd unit files when generating them

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2023
@VannTen
Copy link
Contributor Author

VannTen commented Nov 6, 2023 •
edited
Loading

Hum
I wonder if systemd-analyze in the CI has support for the aliasing stuff. It appears to only be merged since systemd 250
systemd/systemd@da845da

floryut
floryut approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen Thank you for the PR 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@MrFreezeex
Copy link
Member

Hi! FYI the CI failure looks related

@VannTen
Copy link
Contributor Author

VannTen commented Nov 8, 2023

Yeah systemd-analyze support for aliasing (actual_filename:unit.name syntax) is only in since v250 (ish) and ubuntu is only on v246 or something like that.
/hold
(until we have moved to newer versions)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023
@yankay
Copy link
Member

yankay commented Nov 15, 2023

/ok-to-test

@VannTen
Copy link
Contributor Author

VannTen commented Nov 17, 2023

I added a pretty horrible hack to only check on systemd>= 250 without executing another task. (see the commit message)
It might not be worth it ^^

@MrFreezeex
Copy link
Member

Hmmm I think it could be fine a small fixme comment could be nice to explain that It tries to check systemd version >= 250 and that It should be removed whenever we would no longer support with those systemd versions.

Also you should rebase your PR to make the galaxy job happy :D

@VannTen
Validate systemd unit files
6b72d3f 
This ensure that we fail early if we have a bad systemd unit file
(syntax error, using a version not available in the local version, etc)
@VannTen
Hack to check systemd version for service files validation
a4096ae 
factory-reset.target was introduced in system 250, same version as the
aliasing feature we need for verifying systemd services with ansible.
So we only actually executes the validation if that target is present.

This is an horrible hack which should be reverted as soon as we drop
support for distributions with systemd<250.
@VannTen VannTen force-pushed the cleanup/validate_systemd_unit_files branch from 9e565f4 to a4096ae Compare November 17, 2023 16:06
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2023
MrFreezeex
MrFreezeex approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VannTen
Copy link
Contributor Author

VannTen commented Nov 17, 2023

/unhold
Let's go with that then

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0d4f57a into kubernetes-sigs:master Nov 17, 2023
63 checks passed
@VannTen VannTen mentioned this pull request Nov 28, 2023
Closed
9 tasks
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@VannTen @pedromcpedro
Validate systemd unit files (kubernetes-sigs#10597)
addac68 
* Validate systemd unit files

This ensure that we fail early if we have a bad systemd unit file
(syntax error, using a version not available in the local version, etc)

* Hack to check systemd version for service files validation

factory-reset.target was introduced in system 250, same version as the
aliasing feature we need for verifying systemd services with ansible.
So we only actually executes the validation if that target is present.

This is an horrible hack which should be reverted as soon as we drop
support for distributions with systemd<250.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@floryut floryut floryut approved these changes

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@yankay yankay Awaiting requested review from yankay

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VannTen @k8s-ci-robot @MrFreezeex @yankay @floryut