Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.22] Add hashes for kubernetes 1.26.11, 1.26.10 #10704

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 8, 2023

What type of PR is this?
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

1.26.11 contains a backport of kubernetes/kubernetes#121327 ,which fix a nasty regression on the cronjob controller (controller eating all the CPU).

Does this PR introduce a user-facing change?:

Make kubernetes 1.26.11 default

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2023
@VannTen VannTen force-pushed the release-2.22 branch 2 times, most recently from 4fcb144 to 853b0cd Compare December 8, 2023 12:48
@VannTen VannTen changed the title [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10 [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10 [2.22] Dec 8, 2023
@VannTen VannTen changed the title [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10 [2.22] [2.22] Add hashes for kubernetes 1.26.11, 1.26.10 Dec 8, 2023
This is untested. It passes terraform validate to un-broke the CI.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2023
@yankay
Copy link
Member

yankay commented Dec 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2023
@VannTen VannTen force-pushed the release-2.22 branch 2 times, most recently from 80fde8e to c973eaf Compare December 11, 2023 15:49
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
* tests: replace fedora35 with fedora37

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: replace fedora36 with fedora38

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* docs: update fedora version in docs

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* molecule: upgrade fedora version

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: upgrade fedora images for vagrant and kubevirt

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* vagrant: workaround to fix private network ip address in fedora

Fedora stop supporting syconfig network script so we added a workaround
here
hashicorp/vagrant#12762 (comment)
to fix it.

* netowrkmanager: do not configure dns if using systemd-resolved

We should not configure dns if we point to systemd-resolved.
Systemd-resolved is using NetworkManager to infer the upstream DNS
server so if we set NetworkManager to 127.0.0.53 it will prevent
systemd-resolved to get the correct network DNS server.

Thus if we are in this case we just don't set this setting.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* image-builder: update centos7 image

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* gitlab-ci: mark fedora packet jobs as allow failure

Fedora networking is still broken on Packet, let's mark it as allow
failure for now.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

---------

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@yankay
Copy link
Member

yankay commented Dec 12, 2023

Thanks @VannTen
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7dcbe41 into kubernetes-sigs:release-2.22 Dec 12, 2023
62 checks passed
@VannTen VannTen mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants