-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't overwrite changes to openstack allowed_address_pairs #10760
don't overwrite changes to openstack allowed_address_pairs #10760
Conversation
Hi @rptaylor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @rptaylor |
/ok-to-test |
Thanks for the quick response. /assign miouge1 |
Looks like the tests are successful and everything is ready to go, @Miouge1 can you please approve ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rptaylor Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, rptaylor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ignores changes to allowed_address_pairs for the following openstack_networking_port_v2 resources:
This way users who need to customize openstack allowed address pairs can do so without worrying about
terraform apply
overwriting those changes and possibly breaking their clusters.Which issue(s) this PR fixes:
Fixes #10759
Special notes for your reviewer:
See #10759
Does this PR introduce a user-facing change?: