Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite changes to openstack allowed_address_pairs #10760

Merged

Conversation

rptaylor
Copy link
Contributor

@rptaylor rptaylor commented Jan 2, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

Ignores changes to allowed_address_pairs for the following openstack_networking_port_v2 resources:

  • k8s_master_port
  • k8s_masters_port
  • k8s_master_no_etcd_port
  • k8s_master_no_floating_ip_port
  • k8s_master_no_floating_ip_no_etcd_port
  • k8s_node_port
  • k8s_node_no_floating_ip_port
  • k8s_nodes_port

This way users who need to customize openstack allowed address pairs can do so without worrying about terraform apply overwriting those changes and possibly breaking their clusters.

Which issue(s) this PR fixes:
Fixes #10759

Special notes for your reviewer:
See #10759

Does this PR introduce a user-facing change?:

Don't overwrite changes to openstack allowed_address_pairs #10760

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rptaylor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 2, 2024
@yankay
Copy link
Member

yankay commented Jan 3, 2024

Thanks @rptaylor
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@yankay
Copy link
Member

yankay commented Jan 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2024
@rptaylor
Copy link
Contributor Author

rptaylor commented Jan 3, 2024

Thanks for the quick response.

/assign miouge1

@rptaylor
Copy link
Contributor Author

Looks like the tests are successful and everything is ready to go, @Miouge1 can you please approve ?

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rptaylor Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rptaylor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 54fb75f into kubernetes-sigs:master Jan 22, 2024
65 checks passed
@rptaylor rptaylor deleted the preserve-allowed-address-pairs branch January 22, 2024 19:08
@mzaian mzaian mentioned this pull request Apr 26, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openstack allowed_address_pairs are overwritten by Terraform
5 participants