-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crio_version version comparison #10780
Fix crio_version version comparison #10780
Conversation
Signed-off-by: serge Hartmann <[email protected]>
Hi @ledroide. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@ledroide Thank you very much |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ledroide, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: serge Hartmann <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The syntax
{% if crio_version >= v1.26.0 %}
won't work, and will raise an error.The correct syntax is
{% if crio_version is version('v1.26.0', operator='ge') %}
.Before fix, when running role container-engine/cri-o the crio.conf templates fails with message :