Bump cinder-csi version and switch container registry

[Krast76]

/kind cleanup

What this PR does / why we need it:
Upgrading cinder-csi and switch container registry.

Which issue(s) this PR fixes:

Fixes #10893

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update cinder-csi from 1.22.0 to 1.29.0
Use the new container registry for cinder-csi

[k8s-ci-robot]

Welcome @Krast76!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Krast76. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mzaian]

Hello @Krast76

Thanks for the PR, maybe also it's worth looking at the manifests here https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/cinder-csi-plugin and update the files/templates in https://github.com/kubernetes-sigs/kubespray/tree/master/roles/kubernetes-apps/csi_driver/cinder

[Krast76]

Hello @Krast76

Thanks for the PR, maybe also it's worth looking at the manifests here https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/cinder-csi-plugin and update the files/templates in https://github.com/kubernetes-sigs/kubespray/tree/master/roles/kubernetes-apps/csi_driver/cinder

Hello @mzaian

You right, thanks ! I've updated my PR :)

[mzaian]

Hello @Krast76
Thanks for the PR, maybe also it's worth looking at the manifests here https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/cinder-csi-plugin and update the files/templates in https://github.com/kubernetes-sigs/kubespray/tree/master/roles/kubernetes-apps/csi_driver/cinder

Hello @mzaian

You right, thanks ! I've updated my PR :)

Thanks @Krast76

/ok-to-test

[Krast76]

Hello @Krast76
Thanks for the PR, maybe also it's worth looking at the manifests here https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/cinder-csi-plugin and update the files/templates in https://github.com/kubernetes-sigs/kubespray/tree/master/roles/kubernetes-apps/csi_driver/cinder

Hello @mzaian
You right, thanks ! I've updated my PR :)

Thanks @Krast76

/ok-to-test

I tried the patch on a "test cluster".

It seems that csi-attacher in version v3.3.0 doesn't support the flag --default-fstype.

Should I bump the version of all related csi-* containers also ?

[mzaian]

csi-attacher

I believe you need to sync all the changes between the old/new releases see here: kubernetes/cloud-provider-openstack@v1.22.0...v1.29.0

[Krast76]

csi-attacher

I believe you need to sync all the changes between the old/new releases see here: kubernetes/[email protected]

👍

For the csi related containers, I think that we should create a new variable cinder_csi_*_image_tag like Upcloud and Vsphere CSI do. Currently AWS, Azure, GCP and Cinder CSI rely on csi_attacher_image_tag that make csi update a bit risky.

[Krast76]

@mzaian seems good now

[VannTen]

For the csi related containers, I think that we should create a new variable cinder_csi_*_image_tag like Upcloud and Vsphere CSI do. Currently AWS, Azure, GCP and Cinder CSI rely on csi_attacher_image_tag that make csi update a bit risky.

Hum. What is a bit annoying is that those provider-specific tag will not be handled by the download role (which pre-load images on nodes where needed) AFAICT. It's not the end of the world but it could slow cluster bring up / maybe download 2 tags (the generic + the provider specific).
Anyway, no need to block this for that.
/lgtm

[VannTen]

/assign @liupeng0518 @mzaian
(approval)

[mzaian]

@Krast76 Please have a look at the small change I suggested.

[Krast76]

@Krast76 Please have a look at the small change I suggested.

Which one ?

All the changes for cinder-csi between 1.22.0 and 1.29.0 are in the PR.

May be you mean the change suggested by @VannTen ? But he said that is not mandatory right now ?

[Krast76]

@mzaian could you tell me what changes are you waiting for ? 🙏

[mzaian]

@mzaian could you tell me what changes are you waiting for ? 🙏

Scroll up here and then you could see this below:

[VannTen]

@mzaian I think you didn't submit your review, the comments are marked as "Pending" in your screenshot ^

[mzaian]

@mzaian I think you didn't submit your review, the comments are marked as "Pending" in your screenshot ^

Oh I missed this. sorry :(

[Krast76]

@mzaian I think you didn't submit your review, the comments are marked as "Pending" in your screenshot ^

Oh I missed this. sorry :(

No worries 👍

It's ok now :)

[VannTen]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Krast76, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment