-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to create cilium CNI plugin file when cilium>=1.14.0 #10966
Add configuration to create cilium CNI plugin file when cilium>=1.14.0 #10966
Conversation
Hi @cleman95. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the followup PR on the main branch 👍
/lgtm
/assign @yankay |
Thank you very much @cleman95 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cleman95, MrFreezeex, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is linked to this one #10945 as requested by @yankay.
Cilium 1.14.0 is no longer creating its cni plugin file under /etc/cni/net.d by default. To fix this we must add the write-cni-conf-when-ready key inside the cilium-config configMap .
This will also fix the fact that the keys cilium_cni_exclusive and cilium_cni_log_file are no longer used in this role when deploying cilium >= 1.14.0 .
Which issue(s) this PR fixes:
Fixes #10887
Special notes for your reviewer:
it needs to be cherry-picked to the branch release-2.24 after.
Does this PR introduce a user-facing change?: