Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ansible-core to 2.16.4 #10984

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Mar 6, 2024

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16
-> thus needed for #10983

Regarding the deleted stuff in cloud_playbooks: apparently unused, + the community.google collection has been removed from ansible 9 (considered unmaintained)

Special notes for your reviewer:
The GCE stuff looks unused to me, but please speak if it in fact used.

Does this PR introduce a user-facing change?:

Minimum ansible-core version is now 2.16.4

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Mar 11, 2024

/cc @MrFreezeex
(since you handled the last upgrade ^)

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Mar 11, 2024

/assign @oomichi @floryut

@VannTen
Copy link
Contributor Author

VannTen commented Mar 14, 2024

/assign @mzaian

@mzaian
Copy link
Contributor

mzaian commented Mar 14, 2024

I have no clue about the GCE stuff but else it's okay.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7f6ca80 into kubernetes-sigs:master Mar 14, 2024
60 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request Mar 23, 2024
* upgrade ansible version

Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16

* Remove unused google cloud cloud_playbook

* Fix dpkg_selection on non-existing packages

Needed since ansible-core>2.16, see:
ansible/ansible@f10d11b
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
* upgrade ansible version

Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16

* Remove unused google cloud cloud_playbook

* Fix dpkg_selection on non-existing packages

Needed since ansible-core>2.16, see:
ansible/ansible@f10d11b
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* upgrade ansible version

Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16

* Remove unused google cloud cloud_playbook

* Fix dpkg_selection on non-existing packages

Needed since ansible-core>2.16, see:
ansible/ansible@f10d11b
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
* upgrade ansible version

Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16

* Remove unused google cloud cloud_playbook

* Fix dpkg_selection on non-existing packages

Needed since ansible-core>2.16, see:
ansible/ansible@f10d11b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants