-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ansible-core to 2.16.4 #10984
Conversation
Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16
Needed since ansible-core>2.16, see: ansible/ansible@f10d11b
/cc @MrFreezeex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
/lgtm
/assign @mzaian |
I have no clue about the GCE stuff but else it's okay. /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upgrade ansible version Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16 * Remove unused google cloud cloud_playbook * Fix dpkg_selection on non-existing packages Needed since ansible-core>2.16, see: ansible/ansible@f10d11b
* upgrade ansible version Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16 * Remove unused google cloud cloud_playbook * Fix dpkg_selection on non-existing packages Needed since ansible-core>2.16, see: ansible/ansible@f10d11b
* upgrade ansible version Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16 * Remove unused google cloud cloud_playbook * Fix dpkg_selection on non-existing packages Needed since ansible-core>2.16, see: ansible/ansible@f10d11b
* upgrade ansible version Needed for with_first_found to work correctly: ansible/ansible#70772 fixed in 2.16 * Remove unused google cloud cloud_playbook * Fix dpkg_selection on non-existing packages Needed since ansible-core>2.16, see: ansible/ansible@f10d11b
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Needed for with_first_found to work correctly:
ansible/ansible#70772 fixed in 2.16
-> thus needed for #10983
Regarding the deleted stuff in cloud_playbooks: apparently unused, + the community.google collection has been removed from ansible 9 (considered unmaintained)
Special notes for your reviewer:
The GCE stuff looks unused to me, but please speak if it in fact used.
Does this PR introduce a user-facing change?: