CI: add Ubuntu 24.04 support

[tico88612]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support Ubuntu 24.04

Which issue(s) this PR fixes:

Related #11124

Special notes for your reviewer:

Ubuntu 22.04 Ref. #8958

Does this PR introduce a user-facing change?:

Support Ubuntu 24.04

[k8s-ci-robot]

Hi @tico88612. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

/ok-to-test

[VannTen]

If there is one, please also add a vagrant box in the supported_os map in Vagrantfile. That makes it vastly easier to locally test stuff, rather than relying on CI (on my machine that's 5 minutes vs more than 1 hour)

[ant31]

do you have access the the CI logs ?

here the error:

Tuesday 07 May 2024  11:23:49 +0000 (0:00:01.132)       0:02:36.626 *********** 
FAILED - RETRYING: [instance-1]: Ensure docker packages are installed (4 retries left).
FAILED - RETRYING: [instance-1]: Ensure docker packages are installed (3 retries left).
FAILED - RETRYING: [instance-1]: Ensure docker packages are installed (2 retries left).
FAILED - RETRYING: [instance-1]: Ensure docker packages are installed (1 retries left).
TASK [container-engine/docker : Ensure docker packages are installed] **********
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/container-engine/docker/tasks/main.yml:120
fatal: [instance-1]: FAILED! => {"attempts": 4, "cache_update_time": 1715081056, "cache_updated": true, "changed": false, "msg": "no available installation candidate for containerd.io=1.6.28-1"}

and others:

        "kube-system   coredns-69db55dd76-wmrd9                   0/1     CrashLoopBackOff   4 (32s ago)    2m      10.233.87.129    instance-1   <none>           <none>",

[tico88612]

@ant31 Docker has a history of past commits, so I think I can handle that part, but I don't have any idea about CoreDNS for now.

[ant31]

yes, hard to tell without the pod logs.
You could modify the CI script to fetch the logs of CrashLooping pods, or deploy it in a kind locally or something and check what's up.

[VannTen]

Hugh. I changed the default for `unsafe_show_logs` in vagrant but not in CI... EDIT: in fact it's specified in tests/common/_kubespray_test_settings.yml so that's weird 🤔

[tico88612]

@VannTen How to run local tests via Vagrantfile?

[VannTen]

I think you can run the tests playbook the same way that the other on the vagrant inventory. I don't have the exact commands on top of my head but docs/vagrant.md should have that

[tico88612]

I tested in the local Vagrant and searched for some relevant documentation, but I still had no idea why it happened.

vagrant@kub-1:~$ sudo kubectl logs -n kube-system   coredns-69db55dd76-vh84k
.:53
[INFO] plugin/reload: Running configuration SHA512 = b59f020f1adb6e5c87959bc087937219d9fbc5f07c6c4b35020e657de3e09d7fcc37ed823d95753545db7a75d74f874aa9c61574e83129ec6c4f4fb1f4fe8444
CoreDNS-1.11.1
linux/arm64, go1.20.7, ae2bbc2
[FATAL] plugin/loop: Loop (127.0.0.1:39337 -> :53) detected for zone ".", see https://coredns.io/plugins/loop#troubleshooting. Query: "HINFO 7329737346017710518.3032102461366805169."

(This error wasn't seen in other OS.)

[ant31]

@tico88612
you should look around for all vars that are specific to ubuntu-xx
for example:
your error is probably because this file is missing for ubuntu-24:
https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/node/vars/ubuntu-22.yml

you can copy and create an ubuntu-24.yml

[ant31]

all green ! /lgtm

[yankay]

Thanks @tico88612
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VannTen]

/lgtm

[VannTen]

/lgtm Thanks, hope this finally merge!