Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable epel for amazon linux in CI #11181

Closed
wants to merge 1 commit into from

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 13, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Align CI with the documentation

Should unbreak amazon linux CI.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VannTen
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@yankay
Copy link
Member

yankay commented May 13, 2024

HI @VannTen

I am happy you are fixing the CI at the same time :-)
How about you think about the solution of #11182.
The #11182 tries to keep the Amazon Linux with the same as Redhat, it can make things simpler :-)

@VannTen
Copy link
Contributor Author

VannTen commented May 13, 2024 via email

@yankay
Copy link
Member

yankay commented May 13, 2024

I've gone this way because container-selinux was not installed on Amazon Linux before da3ff1c ; so my PR was going back to that state. That said, if Kubespray does need container-selinux on Amazon Linux, I don't have particular objection. (If we do this though, I think the repo enabling should go in boostrap-os/tasks/amzn.yml)

Thanks @VannTen for the advice, The PR #11182 is changed to boostrap-os/tasks/amzn.yml

According to https://docs.aws.amazon.com/linux/al2023/ug/compare-with-al2.html#building-on-fedora ,

AL2 features a high level of compatibility with CentOS 7, and AL2023 is RPM-based and includes components sourced from multiple versions of Fedora and other distributions, such as CentOS 9 Stream. 

So keeping Amazon Linux simpler to Centos and installing container-selinux is better for maintaince.

@VannTen
Copy link
Contributor Author

VannTen commented May 13, 2024

Replaced by #11182

@VannTen VannTen closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants