Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "support CoreDNS use host network and config dns port (#10617)" #11185

Merged
merged 1 commit into from
May 13, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 13, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
This reverts commit bc5b38a.

Which issue(s) this PR fixes:
Fixes #10860

Special notes for your reviewer:
See #10701 (comment)

Does this PR introduce a user-facing change?:

Fix upgrading DNS from 2.23.* releases

/cherrypick release-2.24

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 13, 2024

/cc @MrFreezeex @mzaian

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d8a4aea into kubernetes-sigs:master May 13, 2024
61 of 62 checks passed
@VannTen
Copy link
Contributor Author

VannTen commented May 19, 2024

/cherrypick release-2.24

@k8s-infra-cherrypick-robot

@VannTen: new pull request created: #11214

In response to this:

/cherrypick release-2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VannTen
Copy link
Contributor Author

VannTen commented May 21, 2024

/cherrypick release-2.24
The other PR being stuck by CI.

@k8s-infra-cherrypick-robot

@VannTen: new pull request could not be created: failed to create pull request against kubernetes-sigs/kubespray#release-2.24 from head k8s-infra-cherrypick-robot:cherry-pick-11185-to-release-2.24: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-11185-to-release-2.24."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-2.24
The other PR being stuck by CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sathieu sathieu mentioned this pull request May 23, 2024
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coredns UDP service port point to TCP pod port when upgrading from 23.*
5 participants