bump docker version for kylin linux #11203
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
Signed-off-by: bo.jiang <[email protected]>
ErikJiang
force-pushed
the
bump_docker_version
branch
from
8260202
to
5ca8ab4
Compare
|
Thanks @ErikJiang /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| '24.0': docker-ce-3:24.0.9-1.el{{ ansible_distribution_major_version }} | ||
| 'stable': docker-ce-3:24.0.9-1.el{{ ansible_distribution_major_version }} | ||
| 'edge': docker-ce-3:24.0.9-1.el{{ ansible_distribution_major_version }} | ||
| '18.09': docker-ce-3:18.09.9-3.el8 |
There was a problem hiding this comment.
Why do we don't use ansible_distribution_major_version anymore here?
There was a problem hiding this comment.
😄 Currently, in the Kylin v10 environment, only Docker RPM packages compatible with CentOS 8 can be used. The previous approach involved using set_fact to set ansible_distribution_major_version to 8 to achieve the desired result. However, this method is not considered best practice and has been deprecated. Therefore, the latest approach is to directly specify the package names related to CentOS 8.
There was a problem hiding this comment.
I see, thanks for your details!
/lgtm
k8s-ci-robot
added
the
lgtm
Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
The Docker version for
Kylin V10distribution hasn't been updated for a long time. I have attempted to update it to version 26.1 and performed deployment verification. It seems to be working fine.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: