Add external_openstack_cacert file from host #11377

Nathanael-Mtd · 2024-07-12T16:38:33Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Same as with the in-tree openstack cloud controller, copy external_openstack_cacert file retrieved from ansible host to the control-plane for secret creation.

Does this PR introduce a user-facing change?:

It remove the needs of manual copy of the openstack ca-cert file to the first control plane.

linux-foundation-easycla · 2024-07-12T16:38:36Z

The committers listed above are authorized under a signed CLA.

✅ login: Nathanael-Mtd / name: Nathanaël M. (5a8e019)

k8s-ci-robot · 2024-07-12T16:38:41Z

Welcome @Nathanael-Mtd!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-07-12T16:38:42Z

Hi @Nathanael-Mtd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mzaian

/ok-to-test

yankay · 2024-07-29T06:52:31Z

/lgtm

yankay · 2024-08-01T04:52:09Z

/retest

ant31 · 2024-08-06T10:29:59Z

/approve

k8s-ci-robot · 2024-08-06T10:30:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, mzaian, Nathanael-Mtd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ant31,mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-08-06T10:41:56Z

New changes are detected. LGTM label has been removed.

Nathanael-Mtd · 2024-09-03T14:54:26Z

Hi @yankay, I made a mistake the last time with a merge request instead of rebase (but fixed since weeks), and lgtm tag was removed. Can you re-check if it's ok, and @ErikJiang can you review this PR please ?
Thank you !

VannTen · 2024-09-28T06:25:52Z

Can you squash the fix commit into the first ? Except that, this should be good.

Nathanael-Mtd · 2024-09-28T16:18:55Z

@VannTen Done. Thank you

VannTen

I missed a few things, see comments.

roles/kubernetes-apps/external_cloud_controller/openstack/tasks/main.yml

VannTen · 2024-09-29T10:04:32Z

roles/kubernetes-apps/external_cloud_controller/openstack/tasks/main.yml

+    mode: "0640"
+  when:
+    - inventory_hostname == groups['kube_control_plane'][0]
+    - external_openstack_cacert is defined


Same as above

Not actually resolved, please remove the is defined check

Nathanael-Mtd · 2024-09-30T14:08:37Z

@VannTen I changed the behavior to make the same configuration as cinder by using cacert directly from hostPath instead of secret

VannTen

(also, don't forge to run pre-commit before pushing (I know I always do !), it helps catch some stuff.

VannTen · 2024-10-03T09:02:25Z

roles/kubernetes-apps/external_cloud_controller/openstack/tasks/main.yml

+    mode: "0640"
+  when:
+    - inventory_hostname == groups['kube_control_plane'][0]
+    - external_openstack_cacert is defined


Not actually resolved, please remove the is defined check

VannTen · 2024-10-03T09:03:11Z

...l_cloud_controller/openstack/templates/external-openstack-cloud-controller-manager-ds.yml.j2

@@ -110,3 +111,9 @@ spec:
      - name: cloud-config-volume
        secret:
          secretName: external-openstack-cloud-config
+{% if external_openstack_cacert is defined and external_openstack_cacert != "" %}


Done, I think it's fine now !

VannTen · 2024-10-03T10:50:58Z

Hum, I didn't mean to remove all the check , only the `is defined` part. The idea basically is that every time we have something like = ```yaml when: - some_var is defined - some_var == 'some_value' ``` we should almost always have instead `some_var` defined to a default value in the role defaults/ folder, and only: ``` when: - some == 'some_value' ``` Is that clearer ? And sorry for the misunderstanding

Nathanael-Mtd · 2024-10-03T11:11:17Z

Yes but I tried to be coherent with cinder config before : https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/csi_driver/cinder/tasks/main.yml#L13
But no problem, I understand now, I will keep the length > 0 !

VannTen · 2024-10-03T11:36:32Z

Don't worry, the codebase does not follow this strictly (T_T) but it should ! That's why I ask for that kind of cleanups in review, so we can tend towards a better state.

VannTen · 2024-10-03T12:24:25Z

Re-reading your changes, isn't that a breaking change ? If I read correctly, changing from slurp to copy means that user who have the external_openstack_cacert on the remote host but not on the ansible control host will be in trouble, right ? /hold (until we clarify this) Could we instead not change that, but define a new variable external_openstack_cacert_content (or a similar name) which would override the result of slurp ? This would also keep the secret mount instead of the hostPath, which is not great (external cloud controller could conceivably run on different hosts than the control plane). Thanks !

Nathanael-Mtd · 2024-10-03T12:52:23Z

Hmm yeah it seems to be a breaking change.
Overall there are something weird in how it works before that PR, because if I'm not wrong the var external_openstack_cloud_config_secret (from External OpenStack Cloud Controller | Get base64 cloud-config step) is made by using values from ansible host, and Get base64 cacert from remote host, no ?

That's what I found out during my deployment

VannTen · 2024-10-08T13:45:27Z

The change appear to have been made in #7603 but I don't get why it changed from copy to slurp 🤔

Nathanael-Mtd · 2024-10-09T10:43:26Z

Oh, I think that's linked to UIDs/GIDs, and I just saw that I use root user in my clusters instead of kube and kube-cert.
I think we can forget my PR. But I still need to figure out why the openstack certificate present on ansible host was not copied to the secret.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 12, 2024

k8s-ci-robot requested review from ErikJiang and mzaian July 12, 2024 16:38

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 12, 2024

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 12, 2024

mzaian reviewed Jul 13, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2024

mzaian approved these changes Jul 26, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024

k8s-ci-robot assigned yankay Jul 29, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024

k8s-ci-robot added the do-not-merge/contains-merge-commits label Aug 6, 2024

Nathanael-Mtd force-pushed the patch-1 branch from 4dca87d to 020feb8 Compare August 6, 2024 10:58

k8s-ci-robot removed the do-not-merge/contains-merge-commits label Aug 6, 2024

Nathanael-Mtd force-pushed the patch-1 branch from 134496f to 5060928 Compare September 3, 2024 14:46

Nathanael-Mtd force-pushed the patch-1 branch from 5060928 to fc7d1de Compare September 24, 2024 07:55

Nathanael-Mtd force-pushed the patch-1 branch from fc7d1de to 3a9ca13 Compare September 28, 2024 16:18

VannTen requested changes Sep 29, 2024

View reviewed changes

Nathanael-Mtd force-pushed the patch-1 branch from 3a9ca13 to 6b6530f Compare September 30, 2024 14:05

VannTen requested changes Oct 3, 2024

View reviewed changes

Nathanael-Mtd force-pushed the patch-1 branch 2 times, most recently from ae70919 to 59be5f5 Compare October 3, 2024 10:32

Copy external_openstack_cacert to control-planes from host

5a8e019

Nathanael-Mtd force-pushed the patch-1 branch from 59be5f5 to 5a8e019 Compare October 3, 2024 11:12

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add external_openstack_cacert file from host #11377

Add external_openstack_cacert file from host #11377

Nathanael-Mtd commented Jul 12, 2024

linux-foundation-easycla bot commented Jul 12, 2024 •

edited

Loading

k8s-ci-robot commented Jul 12, 2024

k8s-ci-robot commented Jul 12, 2024

mzaian left a comment

yankay commented Jul 29, 2024

yankay commented Aug 1, 2024

ant31 commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

Nathanael-Mtd commented Sep 3, 2024

VannTen commented Sep 28, 2024

Nathanael-Mtd commented Sep 28, 2024

VannTen left a comment

VannTen Sep 29, 2024

VannTen Oct 3, 2024

Nathanael-Mtd commented Sep 30, 2024

VannTen left a comment

VannTen Oct 3, 2024

VannTen Oct 3, 2024

Nathanael-Mtd Oct 3, 2024

VannTen commented Oct 3, 2024 via email

Nathanael-Mtd commented Oct 3, 2024

VannTen commented Oct 3, 2024 via email

VannTen commented Oct 3, 2024 via email

Nathanael-Mtd commented Oct 3, 2024

VannTen commented Oct 8, 2024

Nathanael-Mtd commented Oct 9, 2024

Add external_openstack_cacert file from host #11377

Are you sure you want to change the base?

Add external_openstack_cacert file from host #11377

Conversation

Nathanael-Mtd commented Jul 12, 2024

linux-foundation-easycla bot commented Jul 12, 2024 • edited Loading

k8s-ci-robot commented Jul 12, 2024

k8s-ci-robot commented Jul 12, 2024

mzaian left a comment

Choose a reason for hiding this comment

yankay commented Jul 29, 2024

yankay commented Aug 1, 2024

ant31 commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

Nathanael-Mtd commented Sep 3, 2024

VannTen commented Sep 28, 2024

Nathanael-Mtd commented Sep 28, 2024

VannTen left a comment

Choose a reason for hiding this comment

VannTen Sep 29, 2024

Choose a reason for hiding this comment

VannTen Oct 3, 2024

Choose a reason for hiding this comment

Nathanael-Mtd commented Sep 30, 2024

VannTen left a comment

Choose a reason for hiding this comment

VannTen Oct 3, 2024

Choose a reason for hiding this comment

VannTen Oct 3, 2024

Choose a reason for hiding this comment

Nathanael-Mtd Oct 3, 2024

Choose a reason for hiding this comment

VannTen commented Oct 3, 2024 via email

Nathanael-Mtd commented Oct 3, 2024

VannTen commented Oct 3, 2024 via email

VannTen commented Oct 3, 2024 via email

Nathanael-Mtd commented Oct 3, 2024

VannTen commented Oct 8, 2024

Nathanael-Mtd commented Oct 9, 2024

linux-foundation-easycla bot commented Jul 12, 2024 •

edited

Loading