Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for standalone tests #6043

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Apr 28, 2020

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Default value for tests are needed (ipip was wrong and should default to true, network_plugin might not be set)

Which issue(s) this PR fixes:
Error in CI

fatal: [530113196-k8s-node-nf-1]: FAILED! => {"msg": "The conditional check 'kube_network_plugin == 'flannel'' failed. The error was: error while evaluating conditional (kube_network_plugin == 'flannel'): 'kube_network_plugin' is undefined\n\nThe error appears to be in '/builds/kargo-ci/kubernetes-sigs-kubespray/tests/testcases/040_check-network-adv.yml': line 17, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n tasks:\n - name: Flannel | Disable tx and rx offloading on VXLAN interfaces (see https://github.com/coreos/flannel/pull/1282)\n ^ here\n"}
...ignoring

Special notes for your reviewer:
roles\network_plugin\calico\defaults\main.yml:10 -> ipip: true

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2020
@Miouge1 Miouge1 added this to the 2.13 milestone Apr 29, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit a468954 into kubernetes-sigs:master Apr 29, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants