Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove variable 'etcd_ionice' #6735

Merged
merged 1 commit into from
Sep 23, 2020
Merged

remove variable 'etcd_ionice' #6735

merged 1 commit into from
Sep 23, 2020

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Sep 23, 2020

because ionice removed from container image etcd:v3.4.x

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:

etcd v3.4.3 failed to launch? when etcd_ionice variable exists

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2020
@EppO
Copy link
Contributor

EppO commented Sep 23, 2020

didn't know about etcd_ionice, good catch

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@floryut
Copy link
Member

floryut commented Sep 23, 2020

Nice indeed, don't really want to check the etcd image so trusting you there ;)

@k8s-ci-robot k8s-ci-robot merged commit c0fd5b2 into kubernetes-sigs:master Sep 23, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 23, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
d068d01 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  remove variable 'etcd_ionice', because ionice removed from container image etcd:v3.4.x (kubernetes-sigs#6735)
  calico: default to using kdd datastore (kubernetes-sigs#6693)
  Update docker packages to 19.03.13 + add docker f32 (kubernetes-sigs#6712)
  Fix snapshot.storage apiVersion (kubernetes-sigs#6711)
  properly generate extravolumes in kubeadmconfig for centos (kubernetes-sigs#6708)
  Fix reserved memory unit in kubelet configuration (kubernetes-sigs#6725)
  Fix unintended SIGPIPE (kubernetes-sigs#6721)
  Expose offline install overrides in inventory (kubernetes-sigs#6728)
  Added ability to set calico vxlan vni and port. defaults to calico's … (kubernetes-sigs#6678)
  Change health check from TCP to HTTPS (kubernetes-sigs#6487)
  Add multi architeture support to flannel (kubernetes-sigs#6166)
  Remove pypi repo and pip extra flags (kubernetes-sigs#6729)
  Fails if kubeadm_version do not matches kubernetes version (kubernetes-sigs#6302)
  Add external_openstack_lbaas_provider setting for occm (kubernetes-sigs#6566)
  add new variable allowing additionnal audit webhook server options (kubernetes-sigs#6726)
  Fix example value for etcd_quota_backend_bytes (kubernetes-sigs#6724)
  Added support for setting tiller_service_account and tiller_replicas (kubernetes-sigs#6696)
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@LuckySB
remove variable 'etcd_ionice', because ionice removed from container …
1a331e6 
…image etcd:v3.4.x (kubernetes-sigs#6735)
@Dentrax
Copy link
Contributor

Dentrax commented Nov 15, 2023

Is there any particular reason why we removed this?

Since etcd mention ionice at their "disk tuning" page: https://etcd.io/docs/v3.4/tuning/#disk

/cc @floryut @LuckySB @woopstar

@k8s-ci-robot
Copy link
Contributor

@Dentrax: GitHub didn't allow me to request PR reviews from the following users: LuckySB.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Is there any particular reason why we removed this?

Since etcd mention ionice at their "disk tuning" page: https://etcd.io/docs/v3.4/tuning/#disk

/cc @floryut @LuckySB @woopstar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floryut
Copy link
Member

floryut commented Nov 17, 2023

Is there any particular reason why we removed this?

Since etcd mention ionice at their "disk tuning" page: https://etcd.io/docs/v3.4/tuning/#disk

/cc @floryut @LuckySB @woopstar

because /bin/ionice is no more present in etcd coreos docker image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

@woopstar woopstar Awaiting requested review from woopstar

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LuckySB @k8s-ci-robot @EppO @floryut @Dentrax