Ensure crio service state #6753

hafe · 2020-09-25T15:22:34Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6746

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2020-09-25T15:22:42Z

Hi @hafe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floryut · 2020-09-25T15:26:44Z

@spaced /poke

floryut · 2020-09-25T15:26:52Z

/ok-to-test

EppO · 2020-09-25T15:46:07Z

fatal: [ubuntu1804]: FAILED! => {"changed": false, "msg": "Could not find the requested service crio: host"}

miss a systemctl daemon-reload maybe?

spaced · 2020-09-25T20:29:27Z

roles/container-engine/cri-o/tasks/main.yaml

+  service:
+    name: crio
+    enabled: yes
+    state: started


why do you think it is needed here again? there is already a handler for

Because I had a special case with crio installed but stopped. The role does not handle that case. The docker role has a similar task

true, if nothing changes but crio is stopped

spaced · 2020-09-25T20:47:46Z

roles/container-engine/cri-o/tasks/main.yaml

+  service:
+    name: crio
+    enabled: yes
+    state: started


true, if nothing changes but crio is stopped

hafe · 2020-09-28T06:29:00Z

fatal: [ubuntu1804]: FAILED! => {"changed": false, "msg": "Could not find the requested service crio: host"}

miss a systemctl daemon-reload maybe?

Definitely!

hafe · 2020-09-28T06:53:19Z

Daemon reload was not enough, something is different with Ubuntu. I need to fire up a local VM and inspect

EppO · 2020-09-28T22:46:59Z

/lgtm

floryut · 2020-09-29T06:47:11Z

@spaced Happy with this version ?

floryut · 2020-10-07T07:06:06Z

Ok let's roll with this.
/approve

k8s-ci-robot · 2020-10-07T07:06:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, hafe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ster * 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits) Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800) Update bunch of dependencies (kubernetes-sigs#6801) If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable. This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520) crio: ensure service is started and enabled (kubernetes-sigs#6753) Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798) Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785) Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786) Use v2.14.1 as base image for CI (kubernetes-sigs#6773) Add oomichi to reviewers (kubernetes-sigs#6796) Update triage/support label references to kind/support (kubernetes-sigs#6792) Update kube-router to 1.1.0 (kubernetes-sigs#6793) harden reset to work in more cases (kubernetes-sigs#6781) Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783) Update cilium with minor fix for CVE (kubernetes-sigs#6784) Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774) Remove arch from flannel image tag (kubernetes-sigs#6765) nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768) Forgotten debian10 test during nightly tests (kubernetes-sigs#6769) ...

* 'master' of https://github.com/kubernetes-sigs/kubespray: crio: ensure service is started and enabled (kubernetes-sigs#6753) Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798) Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785) Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786) Use v2.14.1 as base image for CI (kubernetes-sigs#6773) Add oomichi to reviewers (kubernetes-sigs#6796)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020

k8s-ci-robot requested review from bozzo and EppO September 25, 2020 15:22

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2020

hafe changed the title ~~Crio 6746~~ Fix crio service state and cgroup driver detection Sep 25, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020

spaced reviewed Sep 25, 2020

View reviewed changes

spaced approved these changes Sep 25, 2020

View reviewed changes

hafe force-pushed the crio-6746 branch from 6aabefe to 6604269 Compare September 28, 2020 06:13

hafe force-pushed the crio-6746 branch from 6604269 to 8bb5937 Compare September 28, 2020 18:10

hafe changed the title ~~Fix crio service state and cgroup driver detection~~ Ensure crio service state Sep 28, 2020

crio: ensure service is started and enabled

2dc87b9

hafe force-pushed the crio-6746 branch from 8bb5937 to 2dc87b9 Compare September 28, 2020 18:12

k8s-ci-robot assigned EppO Sep 28, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020

k8s-ci-robot merged commit 99b8f09 into kubernetes-sigs:master Oct 7, 2020

floryut mentioned this pull request Dec 19, 2020

Release Proposal v2.15 #7069

Closed

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021

crio: ensure service is started and enabled (kubernetes-sigs#6753)

a364c94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure crio service state #6753

Ensure crio service state #6753

hafe commented Sep 25, 2020 •

edited

Loading

k8s-ci-robot commented Sep 25, 2020

floryut commented Sep 25, 2020

floryut commented Sep 25, 2020

EppO commented Sep 25, 2020

spaced Sep 25, 2020

hafe Sep 25, 2020

spaced Sep 25, 2020

spaced Sep 25, 2020

hafe commented Sep 28, 2020

hafe commented Sep 28, 2020

EppO commented Sep 28, 2020

floryut commented Sep 29, 2020

floryut commented Oct 7, 2020

k8s-ci-robot commented Oct 7, 2020

Ensure crio service state #6753

Ensure crio service state #6753

Conversation

hafe commented Sep 25, 2020 • edited Loading

k8s-ci-robot commented Sep 25, 2020

floryut commented Sep 25, 2020

floryut commented Sep 25, 2020

EppO commented Sep 25, 2020

spaced Sep 25, 2020

Choose a reason for hiding this comment

hafe Sep 25, 2020

Choose a reason for hiding this comment

spaced Sep 25, 2020

Choose a reason for hiding this comment

spaced Sep 25, 2020

Choose a reason for hiding this comment

hafe commented Sep 28, 2020

hafe commented Sep 28, 2020

EppO commented Sep 28, 2020

floryut commented Sep 29, 2020

floryut commented Oct 7, 2020

k8s-ci-robot commented Oct 7, 2020

hafe commented Sep 25, 2020 •

edited

Loading