Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handlers naming issue for Kubeadm | kubelet #6803

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Fix handlers naming issue for Kubeadm | kubelet #6803

merged 1 commit into from
Oct 11, 2020

Conversation

Avtandilko
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Handlers with the same name (Kubeadm | restart kubelet) leads to incorrect playbook execution. As a result, after completing the tasks, kubelet does not restart. This PR fix this behavior

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Avtandilko
Fix handler naming issue for Kubeadm | kubelet
be9c8c0 
Handlers with the same name (Kubeadm | restart kubelet) leads to incorrect playbook execution. As a result, after completing the tasks, kubelet does not restart. This PR fix this behavior
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Avtandilko. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2020
@Avtandilko Avtandilko changed the title Fix handler naming issue for Kubeadm | kubelet Fix handlers naming issue for Kubeadm | kubelet Oct 7, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2020
@oomichi
Copy link
Contributor

oomichi commented Oct 8, 2020

/ok-to-test
/cc @oomichi

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2020
@floryut
Copy link
Member

floryut commented Oct 8, 2020 •
edited
Loading

This change is pretty recent but it is indeed weird, don't know why we didn't see the missmatch in name 🤔
#6482

@oomichi
Copy link
Contributor

oomichi commented Oct 8, 2020

Nice point.
The renaming was for ansible match the handler by alphabet order, right?
It is better to get feedback from @liupeng0518 before reverting the change to avoid re-reverting PR again.

@woopstar
Copy link
Member

woopstar commented Oct 9, 2020

/approve

it's ok with me. @floryut you ok with this?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avtandilko, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@floryut
Copy link
Member

floryut commented Oct 9, 2020

/approve

it's ok with me. @floryut you ok with this?

Kind of OK, but it would be nice to have a say from @liupeng0518

@LuckySB
Copy link
Contributor

LuckySB commented Oct 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit cb57c3c into kubernetes-sigs:master Oct 11, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Oct 13, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
49b541f 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  change owner to root for bin_dir directory (kubernetes-sigs#6814)
  Modify imagepullpolicy (kubernetes-sigs#6816)
  fix: add tags for set facts nodelocaldns (kubernetes-sigs#6813)
  Make reset work for crio (kubernetes-sigs#6812)
  Added option to force apiserver and respective client certificate to … (kubernetes-sigs#6403)
  cleanup kubelet_deployment_type (kubernetes-sigs#6815)
  allow pre-existing floating IPs to be specified with k8s_master_fips (kubernetes-sigs#6755)
  Fix line-spacing in no_proxy.yml (kubernetes-sigs#6810)
  Fix handler naming issue for Kubeadm | kubelet (kubernetes-sigs#6803)
  Disable dashboard by default (kubernetes-sigs#6804)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@LuckySB LuckySB

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Avtandilko @k8s-ci-robot @oomichi @floryut @woopstar @LuckySB