Remove executable bit from some files

[dchusovitin]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
It's just chmod -x

I think the executable bit was originally added by mistake. It is not necessary because these files are not locally executed. When copying to the server, the correct permissions are set.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @dchusovitin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oomichi]

I agree to remove executable bit from yml files but it also is fine to keep the bit on files which contain #!/bin/bash even if it doesn't affect actual operation.
I'd like to see other opinions.

/ok-to-test
/lgtm

[floryut]

I agree to remove executable bit from yml files but it also is fine to keep the bit on files which contain #!/bin/bash even if it doesn't affect actual operation.
I'd like to see other opinions.

/ok-to-test
/lgtm

Kind of agree with you, great cleanup but we might keep the +x on sh file, doesn't hurt and might be useful for guys cloning and executing directly (I sometime do weird thing like that 😄 )

[dchusovitin]

@oomichi, @floryut

Maybe you are right, but most of these scripts requires root privileges on your local host and can affect your file system. If you are sure that you need this, you can execute sudo sh ./script.sh

• Root privileges required (writes to /opt/bin)

roles/bootstrap-os/files/bootstrap.sh

• Contains jinja2 syntax ({{ x }}), so you get a syntax error

roles/etcd/templates/etcd.j2
roles/etcd/templates/make-ssl-etcd.sh.j2

• Root privileges required (ip link ...)

roles/network_plugin/macvlan/files/ifup-macvlan
roles/network_plugin/macvlan/files/ifup-local
roles/network_plugin/macvlan/files/ifdown-macvlan

Of course, I can restore +x on these files.

[oomichi]

I just don't have strong opinion to say "please don't do that" when someone add executable bit for such files.
Either is fine, that is the reason why I already put my lgtm :-)

[dchusovitin]

It's a little bit confusing, if you are working in a terminal.

[electrocucaracha]

I noticed that this PR modifies some templates and files so I just wondering if it should be nice to modify the ansible task to include the correct mode value for them.

[EppO]

I would keep the +x on the .sh files but I'm fine with the YAML files to be 644.

[dchusovitin]

chmod -x only on yaml and j2
Branch is up to date with the latest master.

[LuckySB]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchusovitin, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LuckySB]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

Thanks

/lgtm