-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calico: update files to handle multi-asn bgp peering conditions. #6971
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @catblade. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: catblade, mirwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
…ernetes-sigs#6971) * update files to handle multi-asn bgp peering conditions. * put back in the serviceClusterIPs. Bad merge. * remove extraneous environment var. * update files as discussed with mirwan * update titles. * add not in. * add a conditional for using bgp to advertise cluster ips. Co-authored-by: marlow-h <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Without these changes, multi-ASN configs will not work.
Tested on our little cluster with a switch. Do not see infrastructure in kubepsray proper to test this type of config (needs switch configuration to test). We have an iperf test that works with these changes.
Which issue(s) this PR fixes:
Fixes #
#6845
Special notes for your reviewer:
You may wish to talk to me directly in how to set a switch for testing.
Does this PR introduce a user-facing change?
Yes.
New item in samples shows you can choose not to set a global calico ASN, option named calico_no_global_as_num
No longer need to set local_as per-node. It will pull it in from the tors as they are defined by node. This will make changing servers between racks (or otherwise configuring) less prone to user error.