Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gcp terraform support #6974

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Added gcp terraform support #6974

merged 3 commits into from
Dec 24, 2020

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Dec 1, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:

Since the PR #6075 for GCP support seem to be stale I created a new one with some changes.

Provision a Kubernetes cluster on GCP using Terraform

Which issue(s) this PR fixes:

Fixes #5854

Special notes for your reviewer:

To test, read the quickstart section in the README

Does this PR introduce a user-facing change?:

No

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 1, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Xartos!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Xartos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 1, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 1, 2020
@floryut
Copy link
Member

floryut commented Dec 1, 2020

@Xartos Thank you for the PR ! And good thinking, we'll close the olther one when this is merge 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2020
@Xartos
Copy link
Contributor Author

Xartos commented Dec 2, 2020

Sorry for pushing changes, if someone is in the middle of testing, but I realized that there were some major issues that I had missed.

@EppO
Copy link
Contributor

EppO commented Dec 9, 2020

@Miouge1: do we have a GCP account to test this code against?

@floryut
Copy link
Member

floryut commented Dec 21, 2020

What do we do here ? @EppO @oomichi @Miouge1 @LuckySB

@floryut
Copy link
Member

floryut commented Dec 23, 2020

well... all good for me
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Xartos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Dec 24, 2020

at first glance everything is fine

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit bbab101 into kubernetes-sigs:master Dec 24, 2020
@floryut floryut mentioned this pull request Jan 4, 2021
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 17, 2021
@Xartos @LuckySB
Added gcp terraform support (kubernetes-sigs#6974)
ae56ba2 
* Added gcp terraform support

* Added http/https firewall rule

* Ignoring lifecycle changes for attached disks on the google_compute_instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@LuckySB LuckySB

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provision a Kubernetes cluster on GCP using Terraform and Kubespray
5 participants
@Xartos @k8s-ci-robot @floryut @EppO @LuckySB