-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklist Calico's VXLAN interface from NetworkManager #7037
Blacklist Calico's VXLAN interface from NetworkManager #7037
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @teozkr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've lifted it for approval internally. Will come back when I have a response from there.. |
@teozkr commit message is wrong, "calico.vxlan" vs "vxlan.calico". Commit is ok. |
2715041
to
8fd7051
Compare
rebase to fix the ci failure |
See projectcalico/calico#3271 Otherwise Calico can get into a fight with NM about who "owns" the vxlan.calico interface, breaking all pod traffic.
8fd7051
to
df95a3a
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB, teozkr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…gs#7037) See projectcalico/calico#3271 Otherwise Calico can get into a fight with NM about who "owns" the vxlan.calico interface, breaking all pod traffic.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Calico sometimes gets into a fight with NetworkManager about who "owns" the calico.vxlan interface, rapidly bringing it up and down, in turn breaking all pod traffic.
Which issue(s) this PR fixes:
projectcalico/calico#3271
Special notes for your reviewer:
Does this PR introduce a user-facing change?: