Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist Calico's VXLAN interface from NetworkManager #7037

Merged

Conversation

nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 15, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

Calico sometimes gets into a fight with NetworkManager about who "owns" the calico.vxlan interface, rapidly bringing it up and down, in turn breaking all pod traffic.

Which issue(s) this PR fixes:

projectcalico/calico#3271

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed NetworkManager sometimes breaking Calico's VXLAN mode

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @teozkr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2020
@floryut
Copy link
Member

floryut commented Dec 15, 2020

@teozkr Thank you for the PR, could you please sign CLA ?

@nightkr
Copy link
Contributor Author

nightkr commented Dec 15, 2020

I've lifted it for approval internally. Will come back when I have a response from there..

@champtar
Copy link
Contributor

@teozkr commit message is wrong, "calico.vxlan" vs "vxlan.calico". Commit is ok.

@nightkr nightkr force-pushed the bugfix/calico-networkmanager-vxlan branch from 2715041 to 8fd7051 Compare December 22, 2020 15:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 22, 2020
@nightkr
Copy link
Contributor Author

nightkr commented Dec 22, 2020

@floryut CLA should be sorted out now.

@champtar Thanks, fixed.

@champtar
Copy link
Contributor

rebase to fix the ci failure

See projectcalico/calico#3271

Otherwise Calico can get into a fight with NM about who "owns" the vxlan.calico
interface, breaking all pod traffic.
@nightkr nightkr force-pushed the bugfix/calico-networkmanager-vxlan branch from 8fd7051 to df95a3a Compare December 22, 2020 16:11
@LuckySB
Copy link
Contributor

LuckySB commented Dec 23, 2020

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, teozkr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Dec 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 161c7e9 into kubernetes-sigs:master Dec 23, 2020
@floryut floryut mentioned this pull request Jan 4, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 17, 2021
…gs#7037)

See projectcalico/calico#3271

Otherwise Calico can get into a fight with NM about who "owns" the vxlan.calico
interface, breaking all pod traffic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants