-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodelocaldns: allow binding metrics address to host IP #7748
nodelocaldns: allow binding metrics address to host IP #7748
Conversation
Hi @cristicalin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
@@ -17,7 +17,7 @@ data: | |||
loop | |||
bind {{ nodelocaldns_ip }} | |||
forward . {{ block['nameservers'] | join(' ') }} | |||
prometheus :9253 | |||
prometheus {% if nodelocaldns_bind_metrics_host_ip %}{$MY_HOST_IP}{% endif %}:9253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a question about the syntax {$FOO}
, but that seems fine from https://coredns.io/manual/configuration/#environment-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the way Caddyfiles
(the configuration file format used by CoreDNS) do interpolation.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements a boolean
nodelocaldns_bind_metrics_host_ip
that allows a deployer to ensure nodelocaldns prometheus listen interface is bound to the host IP instead of listening on all addresses. This is important to ensure that on multi-homed hosts we don't unnecessarily leak information on additional network interfaces.For better control, deployers should also protect this using host based firewalls or endpoint policies with Calico.
Which issue(s) this PR fixes:
Fixes #7740
Special notes for your reviewer:
Does this PR introduce a user-facing change?: