-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated UpCloud terraform script to use private network and dynamic additional disks #7779
Updated UpCloud terraform script to use private network and dynamic additional disks #7779
Conversation
Hi @Xartos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ewnetu PTAL |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Xartos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
To be able to set up more complex kubernetes clusters in UpCloud, I added the ability to add additional data disks as well as a private network to segregate private and public traffic.
Which issue(s) this PR fixes:
Fixes none
Special notes for your reviewer:
Previously there were a
hostname
variable, which I assume was to separate environments. I have now changed that in favor of a prefix variable, to harmonize with the rest of the terraform scripts in this repo. Although I made it possible to still keep the same name if you set the prefix variable to""
and add the hostname to each nodename instead.Does this PR introduce a user-facing change?: