-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes/preinstall: Add Debian 11 (bullseye) support #7853
Conversation
Hi @rtsp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Add Debian 11 (bullseye) support Signed-off-by: rtsp <[email protected]>
/retest |
@rtsp: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We would need at least one CI test to add this OS as a supported one. |
- Use python3-apt instead because python-apt was removed in Debian 11 - Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed) - Remove aufs-tools Signed-off-by: rtsp <[email protected]>
@floryut Could we reconsider about merging this PR before the CI Tests for Debian 11 is available? Since the kubespray/roles/kubernetes/preinstall/vars/debian.yml Lines 2 to 3 in 425b674
This PR just add extra vars file kubespray/roles/kubernetes/preinstall/vars/debian-11.yml Lines 1 to 7 in 6ca8ac2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@rtsp agreed, I'll try to find time to add image and CI test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, rtsp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
- Use python3-apt instead because python-apt was removed in Debian 11 - Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed) - Remove aufs-tools Signed-off-by: rtsp <[email protected]>
- Use python3-apt instead because python-apt was removed in Debian 11 - Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed) - Remove aufs-tools Signed-off-by: rtsp <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Several packages was removed from Debian 11 (bullseye) resulting to kubespray deploy failed on bullseye target.
This PR just add a new
required_pkgs
vars file specifically for Debian 11 and fix these issuespython-apt
removed => change topython3-apt
aufs-tools
removed => remove from a list (previously used in older version of Docker)gnupg
not installed by default => installgnupg
before runningapt_key
container-engine/containerd : ensure containerd repository public key is installed
task failedkubespray/roles/kubernetes/preinstall/vars/debian-11.yml
Lines 1 to 7 in b72f8cd
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This PR was successfully tested on my cluster with following details
My Test Cluster
Inventory Configuration & Add-ons
Does this PR introduce a user-facing change?: