Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes/preinstall: Add Debian 11 (bullseye) support #7853

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

rtsp
Copy link
Member

@rtsp rtsp commented Aug 5, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Several packages was removed from Debian 11 (bullseye) resulting to kubespray deploy failed on bullseye target.

This PR just add a new required_pkgs vars file specifically for Debian 11 and fix these issues

  • python-apt removed => change to python3-apt
  • aufs-tools removed => remove from a list (previously used in older version of Docker)
  • gnupg not installed by default => install gnupg before running apt_key
    • This fix container-engine/containerd : ensure containerd repository public key is installed task failed

---
required_pkgs:
- python3-apt
- gnupg
- apt-transport-https
- software-properties-common
- conntrack

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

This PR was successfully tested on my cluster with following details

My Test Cluster

  • 3 nodes - 3 masters, worker in master node (4 CPU, 4 GB each)
  • Debian 11 (bullseye) netinst+ssh
  • Restore from snapshot to clean-install state before each test

Inventory Configuration & Add-ons

  1. k8s v1.21.1 with containerd + etcd(host)
  2. k8s v1.21.3 with containerd + etcd(host)
  3. k8s v1.21.3 with containerd + etcd(host) + helm + metrics_server + ingress_nginx + cert_manager + metallb
  4. k8s v.1.21.3 with docker + etcd(docker)
  5. k8s v.1.21.3 with docker + etcd(docker) + helm + metrics_server + ingress_nginx + cert_manager + metallb

Does this PR introduce a user-facing change?:

Add Debian 11 support

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @rtsp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
rtsp added a commit to rtsp/kubespray that referenced this pull request Aug 5, 2021
- Add Debian 11 (bullseye) support

Signed-off-by: rtsp <[email protected]>
@rtsp rtsp marked this pull request as ready for review August 5, 2021 14:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021
@rtsp
Copy link
Member Author

rtsp commented Aug 5, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@rtsp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floryut
Copy link
Member

floryut commented Aug 6, 2021

We would need at least one CI test to add this OS as a supported one.

- Use python3-apt instead because python-apt was removed in Debian 11
- Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed)
- Remove aufs-tools

Signed-off-by: rtsp <[email protected]>
@rtsp
Copy link
Member Author

rtsp commented Aug 27, 2021

We would need at least one CI test to add this OS as a supported one.

@floryut Could we reconsider about merging this PR before the CI Tests for Debian 11 is available?

Since the python-apt package is removed from Debian 11 so it's impossible to deploy current Kubespray on Debian 11 in any case.

required_pkgs:
- python-apt

This PR just add extra vars file debian-11.yml that don't touch any other part of the Kubespray. At least, this would help Debian 11 users to be able to deploy for now.

---
required_pkgs:
- python3-apt
- gnupg
- apt-transport-https
- software-properties-common
- conntrack

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
@rtsp agreed, I'll try to find time to add image and CI test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rtsp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@champtar
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit c8e090c into kubernetes-sigs:master Aug 30, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
- Use python3-apt instead because python-apt was removed in Debian 11
- Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed)
- Remove aufs-tools

Signed-off-by: rtsp <[email protected]>
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
- Use python3-apt instead because python-apt was removed in Debian 11
- Add gnupg (fix "container-engine/containerd : ensure containerd repository public key is installed" task failed)
- Remove aufs-tools

Signed-off-by: rtsp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants