-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kube_config_dir for kubeconfig #7996
Use kube_config_dir for kubeconfig #7996
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I guess we could also update paths in kubespray/roles/kubernetes/control-plane/tasks/kubeadm-setup.yml Lines 153 to 164 in 2211504
And in
|
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
72aabcc
to
39728a5
Compare
@floryut Thank you for your review, that is a nice point. |
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
…-sigs#8037) The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf. Most paths of the file are configurable but some were not. This make those configurable.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf.
Most paths of the file are configurable but some were not.
This make those configurable.
Does this PR introduce a user-facing change?: