-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.17] Remove allowPrivilegeEscalation from metrics-server (#8014) #8025
[2.17] Remove allowPrivilegeEscalation from metrics-server (#8014) #8025
Conversation
…8014) "allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7. In addition, the original metrics-server manifest doesn't contain it as [1]. This removes it. [1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…8014) (kubernetes-sigs#8025) "allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7. In addition, the original metrics-server manifest doesn't contain it as [1]. This removes it. [1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
…8014) (kubernetes-sigs#8025) "allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7. In addition, the original metrics-server manifest doesn't contain it as [1]. This removes it. [1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
…8014) (kubernetes-sigs#8025) "allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7. In addition, the original metrics-server manifest doesn't contain it as [1]. This removes it. [1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
What type of PR is this?
/kind bug
What this PR does / why we need it:
"allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7.
In addition, the original metrics-server manifest doesn't contain it as 1. This removes it.
Which issue(s) this PR fixes:
Fixes #7988
Special notes for your reviewer:
This is a backporting pull request of #8014 for release-2.17 branch.
Does this PR introduce a user-facing change?: