Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.17] Remove allowPrivilegeEscalation from metrics-server (#8014) #8025

Merged

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Sep 27, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

"allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7.
In addition, the original metrics-server manifest doesn't contain it as 1. This removes it.

Which issue(s) this PR fixes:

Fixes #7988

Special notes for your reviewer:

This is a backporting pull request of #8014 for release-2.17 branch.

Does this PR introduce a user-facing change?:

Fix CentOS7 issue with allowPrivilegeEscalation value from metrics-server

…8014)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2021
@oomichi oomichi changed the title Remove allowPrivilegeEscalation from metrics-server (#8014) [2.17] Remove allowPrivilegeEscalation from metrics-server (#8014) Sep 27, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6cfa3bb into kubernetes-sigs:release-2.17 Sep 28, 2021
huangkevin404 pushed a commit to wiremind/kubespray that referenced this pull request Sep 15, 2022
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
skw0823 pushed a commit to skw0823/kubespray that referenced this pull request Mar 2, 2023
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
skw0823 pushed a commit to skw0823/kubespray that referenced this pull request Mar 6, 2023
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants