-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registry template #8198
Update registry template #8198
Conversation
Hi @zhengtianbao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do all storage backends support multiple registry replicas? Maybe there should be a sanity check as well. |
Thanks for your review, I suppose we can't do the check because have no idea what |
You can still check if On a second note, I think adding this parametrization warrants a mention in the docs. |
Co-authored-by: Cristian Calin <[email protected]>
Nice work @zhengtianbao ! /ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengtianbao Thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, zhengtianbao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add registry replica setting * Add registry liveness and readiness probe * Set the security context for registry * Add registry pvc access mode option * registry add replica requirement check * docs: add registry replicas setting note * Update docs/kubernetes-apps/registry.md Co-authored-by: Cristian Calin <[email protected]> Co-authored-by: Cristian Calin <[email protected]>
* Add registry replica setting * Add registry liveness and readiness probe * Set the security context for registry * Add registry pvc access mode option * registry add replica requirement check * docs: add registry replicas setting note * Update docs/kubernetes-apps/registry.md Co-authored-by: Cristian Calin <[email protected]> Co-authored-by: Cristian Calin <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR add extra options of docker registry yaml config
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: