Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry template #8198

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Update registry template #8198

merged 7 commits into from
Nov 22, 2021

Conversation

zhengtianbao
Copy link
Member

@zhengtianbao zhengtianbao commented Nov 16, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR add extra options of docker registry yaml config

  • Add liveness and readiness Probes
  • Add Replica setting for HA
  • Set the security context

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update registry template with additional options (security context and proves) and variables (`registry_storage_access_mode` to changes access mode, `registry_replica_count` for replicas)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2021
@cristicalin
Copy link
Contributor

Do all storage backends support multiple registry replicas? Maybe there should be a sanity check as well.

@zhengtianbao
Copy link
Member Author

Do all storage backends support multiple registry replicas? Maybe there should be a sanity check as well.

Thanks for your review, I suppose we can't do the check because have no idea what registry_storage_class will be used by user setting. kubespray will deploy registry use emptyDir as volume by default. If user set the option registry_storage_class, they should know that if the storageClass provisioner support multi replicas reading and writing data simultaneously.

@cristicalin
Copy link
Contributor

You can still check if registry_storage_class and registry_storage_access_mode is ReadWriteMany.

On a second note, I think adding this parametrization warrants a mention in the docs.

@cristicalin
Copy link
Contributor

Nice work @zhengtianbao !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2021
@jayonlau
Copy link
Contributor

/lgtm

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit e35a87e into kubernetes-sigs:master Nov 22, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Add registry replica setting

* Add registry liveness and readiness probe

* Set the security context for registry

* Add registry pvc access mode option

* registry add replica requirement check

* docs: add registry replicas setting note

* Update docs/kubernetes-apps/registry.md

Co-authored-by: Cristian Calin <[email protected]>

Co-authored-by: Cristian Calin <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
* Add registry replica setting

* Add registry liveness and readiness probe

* Set the security context for registry

* Add registry pvc access mode option

* registry add replica requirement check

* docs: add registry replicas setting note

* Update docs/kubernetes-apps/registry.md

Co-authored-by: Cristian Calin <[email protected]>

Co-authored-by: Cristian Calin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants