-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong baseurl for centos extra repo for Oracle Linux #8208
Fix wrong baseurl for centos extra repo for Oracle Linux #8208
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @buker! |
Hi @buker. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
86100a3
to
a58c068
Compare
Hi @buker , thank you for this fix. Please sign the CLA so we may include this fix: https://git.k8s.io/community/CLA.md#the-contributor-license-agreement |
a58c068
to
44a6a59
Compare
44a6a59
to
8f97d84
Compare
@@ -79,7 +79,7 @@ | |||
- { option: "name", value: "CentOS-{{ ansible_distribution_major_version }} - Extras" } | |||
- { option: "enabled", value: "1" } | |||
- { option: "gpgcheck", value: "0" } | |||
- { option: "baseurl", value: "http://mirror.centos.org/centos/{{ ansible_distribution_major_version }}/extras/$basearch/" } | |||
- { option: "baseurl", value: "http://mirror.centos.org/centos/{{ ansible_distribution_major_version }}/extras/$basearch/os/" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems valid as we can see repomd.xml under http://mirror.centos.org/centos/8/extras/x86_64/os/repodata/
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to run the test..
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buker Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buker, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems this change broke OEL7 support see https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1804750376#L1514, the repo convention is different for CentOS Extras 7 vs CentOS Extras 8. On a second note, how will this affect our ability to deploy on OEL8 post CentOS 8 EOL? |
What type of PR is this?
What this PR does / why we need it:
Fixing issue #8207
Which issue(s) this PR fixes:
Fixes #8207
Special notes for your reviewer:
Does this PR introduce a user-facing change?: