-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce calico bird route removal time to improving Kubernetes node removal performance #8227
Reduce calico bird route removal time to improving Kubernetes node removal performance #8227
Conversation
Welcome @khatrig! |
Hi @khatrig. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jayonlau , can you please help review this? |
I don't think it is really the intention to reset a cluster with running workloads on it but a speed improvement is welcomed for sure. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khatrig Thanks for the PR, this looks fine, perf improvement ftw 😉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, khatrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As part of Kubernetes node removal, calico bird route cleanup on large clusters(3000+ pods running) takes 45+ minutes. This PR reduces the reset playbook runtime to less than one minute.
Which issue(s) this PR fixes:
Fixes # 8116
Special notes for your reviewer:
Does this PR introduce a user-facing change?: