-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for boot volume type for k8s node #8256
Add option for boot volume type for k8s node #8256
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @robinAwallace. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @robinAwallace! |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@robinAwallace Thank you for the PR, could you please sign CLA ? |
/check-cla |
@robinAwallace I still needed to tick "contributing employee" next to your name in the CLA portal before you officially signed the CLA. Sorry for not having communicated this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robinAwallace Thanks for the PR 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, OlleLarsson, robinAwallace The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently it is just possible to set the boot volume type for master nodes in terraform vars.
This PR adds the option to set the boot from volume type for k8s nodes in terrafrom vars.
This option can be set by adding the following in terraform vars
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Does this PR introduce a user-facing change?: