Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: don't set calico_vxlan_mode_ipv6=vxlanAlways when kernel < 3.12 #9645

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

cyclinder
Copy link
Contributor

@cyclinder cyclinder commented Jan 6, 2023

Signed-off-by: cyclinder [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

doc: don't set calico_vxlan_mode_ipv6=vxlanAlways when kernel < 3.12

Which issue(s) this PR fixes:

Fixes projectcalico/calico#6877

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[calico]: don't set calico_vxlan_mode_ipv6=vxlanAlways when kernel < 3.12

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2023
@yankay
Copy link
Member

yankay commented Jan 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@oomichi
Copy link
Contributor

oomichi commented Jan 8, 2023

It is better to wait for projectcalico/calico#6877 is closed to see the conclusions on Calico side before this pull request.

@cyclinder
Copy link
Contributor Author

@oomichi projectcalico/calico#6877 has been merged, so i think this PR is ready to merged.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2023
@oomichi
Copy link
Contributor

oomichi commented Jan 16, 2023

@oomichi projectcalico/calico#6877 has been merged, so i think this PR is ready to merged.

Thank you for letting me know that.
Now it looks good for me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyclinder Thank you 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 85a5a79 into kubernetes-sigs:master Jan 16, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calico pod cross-node access failed with ipv6
5 participants