Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the bazel version from test. #265

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Delete the bazel version from test. #265

merged 1 commit into from
Jul 2, 2024

Conversation

jbtk
Copy link
Contributor

@jbtk jbtk commented May 9, 2024

Otherwise the test fails with "Current Bazel version is 5.3.0, expected at least 5.4.0".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jbtk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
@jbtk jbtk mentioned this pull request May 9, 2024
Closed
BenTheElder
BenTheElder reviewed May 9, 2024
View reviewed changes
kubetest2-gce/ci-tests/buildupdown.sh Outdated
@@ -29,7 +29,7 @@ make install-tester-ginkgo
REPO_ROOT="${GOPATH}"/src/k8s.io/cloud-provider-gcp;

# TODO(spiffxp): remove this when cloudprovider-gcp has a .bazelversion file
export USE_BAZEL_VERSION=5.3.0
export USE_BAZEL_VERSION=5.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should really control this from cloudprovider-gcp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @seans3

@jbtk
Copy link
Contributor Author

jbtk commented May 9, 2024

Can we check at least whether with this change the test passes? This test is the only failing in my other PR and since I was able to reproduce without my change I guess that it would fail on current master as well (not sure, was not able to find any CI that would run these tests).

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2024
@jbtk
Delete the bazel version as the cloud-provider-gcp already has .bazel…
a7882e7 
…version. Otherwise the test fails with "Current Bazel version is 5.3.0, expected at least 5.4.0".
@jbtk
Copy link
Contributor Author

jbtk commented May 14, 2024

/test all

@jbtk jbtk changed the title Update the bazel version. Delete the bazel version from test. May 14, 2024
@jbtk jbtk requested a review from BenTheElder May 14, 2024 08:57
TerryHowe
TerryHowe approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is g2g
/lgtm

https://github.com/kubernetes/cloud-provider-gcp/blob/master/.bazelversion

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
BenTheElder
BenTheElder reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jbtk
Copy link
Contributor Author

jbtk commented Jun 11, 2024

/assign mushuee

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenTheElder, jbtk, TerryHowe, upodroid
Once this PR has been reviewed and has the lgtm label, please ask for approval from mushuee. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid upodroid merged commit ae94546 into kubernetes-sigs:master Jul 2, 2024
11 of 12 checks passed
@BenTheElder
Copy link
Member

mushuee

I don't think @MushuEE is doing OSS development these days and we should probably update OWNERS. (spiffxp is not either)

maybe @aojea wants more to do ;-)

@aojea
Copy link
Contributor

aojea commented Jul 3, 2024

maybe @aojea wants more to do ;-)

#267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@upodroid upodroid upodroid approved these changes

@TerryHowe TerryHowe TerryHowe approved these changes

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@TerryHowe TerryHowe

@BenTheElder BenTheElder

@MushuEE MushuEE

@upodroid upodroid

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jbtk @k8s-ci-robot @BenTheElder @aojea @TerryHowe @upodroid @MushuEE