Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat tables. #3048

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Reformat tables. #3048

merged 1 commit into from
Sep 13, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reformat tables.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit f229c16
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66e488901a667900083a948f
😎 Deploy Preview https://deploy-preview-3048--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi mentioned this pull request Sep 13, 2024
Merged
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

alculquicondor
alculquicondor reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7da0ba963849b8ad185ab78a6de12e0fc5069977

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit cb18c75 into kubernetes-sigs:main Sep 13, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 13, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/reformat-tables branch September 13, 2024 20:27
@mimowo
Copy link
Contributor

mimowo commented Sep 16, 2024

/cherry-pick website
So that other cherry-picks to website don't run into conflicts.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #3048 failed to apply on top of branch "website":

Applying: Reformat tables.
Using index info to reconstruct a base tree...
M	site/content/en/docs/installation/_index.md
Falling back to patching base and 3-way merge...
Auto-merging site/content/en/docs/installation/_index.md
CONFLICT (content): Merge conflict in site/content/en/docs/installation/_index.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Reformat tables.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick website
So that other cherry-picks to website don't run into conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor

mimowo commented Sep 16, 2024

@mbobrovskyi could you prepare a manual cherry-pick?

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Sep 16, 2024 •
edited
Loading

Should we rebase this branch before #2909? It will change nothing on the site. But in the future we will need to rebase it again.

@mimowo
Copy link
Contributor

mimowo commented Sep 16, 2024

I don't think #2909 is planned for cherry-picking (it is a new feature impacting API)

@mbobrovskyi mbobrovskyi mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@mbobrovskyi @k8s-ci-robot @mimowo @k8s-infra-cherrypick-robot @alculquicondor