Merge pull request #1302 from mmb/nginx-auth-tls-secret

Add support for nginx.ingress.kubernetes.io/auth-tls-secret
kubernetes-sigs · Jul 3, 2019 · e0bac6a · e0bac6a
2 parents d841d1b + 0d87cd6
commit e0bac6a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/pkg/transformers/config/defaultconfig/namereference.go b/pkg/transformers/config/defaultconfig/namereference.go
@@ -224,6 +224,8 @@ nameReference:
     kind: Ingress
   - path: metadata/annotations/nginx.ingress.kubernetes.io\/auth-secret
     kind: Ingress
+  - path: metadata/annotations/nginx.ingress.kubernetes.io\/auth-tls-secret
+    kind: Ingress
   - path: imagePullSecrets/name
     kind: ServiceAccount
   - path: parameters/secretName

diff --git a/pkg/transformers/namereference_test.go b/pkg/transformers/namereference_test.go
@@ -56,8 +56,9 @@ func TestNameReferenceHappyRun(t *testing.T) {
 			"metadata": map[string]interface{}{
 				"name": "ingress1",
 				"annotations": map[string]interface{}{
-					"ingress.kubernetes.io/auth-secret":       "secret1",
-					"nginx.ingress.kubernetes.io/auth-secret": "secret1",
+					"ingress.kubernetes.io/auth-secret":           "secret1",
+					"nginx.ingress.kubernetes.io/auth-secret":     "secret1",
+					"nginx.ingress.kubernetes.io/auth-tls-secret": "secret1",
 				},
 			},
 			"spec": map[string]interface{}{
@@ -378,8 +379,9 @@ func TestNameReferenceHappyRun(t *testing.T) {
 			"metadata": map[string]interface{}{
 				"name": "ingress1",
 				"annotations": map[string]interface{}{
-					"ingress.kubernetes.io/auth-secret":       "someprefix-secret1-somehash",
-					"nginx.ingress.kubernetes.io/auth-secret": "someprefix-secret1-somehash",
+					"ingress.kubernetes.io/auth-secret":           "someprefix-secret1-somehash",
+					"nginx.ingress.kubernetes.io/auth-secret":     "someprefix-secret1-somehash",
+					"nginx.ingress.kubernetes.io/auth-tls-secret": "someprefix-secret1-somehash",
 				},
 			},
 			"spec": map[string]interface{}{