Allow patch removal of emptyDir {} #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
monopole
requested review from
KnVerey
and removed request for
pwittrock and
Liujingfang1
|
/test kustomize-presubmit-master |
KnVerey
approved these changes
Mar 16, 2021
| var patches []*resource.Resource | ||
| for _, path := range paths { | ||
| // For legacy reasons, attempt to treat the path string as | ||
| // actual patch content. |
There was a problem hiding this comment.
The comment deleted higher up implied an intent to deprecate this behavior. Is that no longer the plan?
There was a problem hiding this comment.
No, i think it's too baked in, and relatively harmless.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3394, and cleanup a loose end from #3304
This also removes two layers of convert to JSON and interpret as YAML from the strategic merge patch code.
ALLOW_MODULE_SPAN