Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to go 1.20 #5187

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Bump to go 1.20 #5187

merged 2 commits into from
Jun 7, 2023

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented May 31, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 31, 2023
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koba1t
Copy link
Member Author

koba1t commented May 31, 2023

Hi @natasha41575

I think the prow check is passed.
Could you check and please tell me if you have a point that is needed to test?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
@koba1t koba1t force-pushed the update_go_1.20 branch 2 times, most recently from b0289e2 to 0c6fa63 Compare June 6, 2023 15:18
@koba1t
Copy link
Member Author

koba1t commented Jun 6, 2023

kubernetes/kube-openapi#402
kube-openapi is breaking change its dependencies.

# sigs.k8s.io/kustomize/kyaml/openapi
../pkg/mod/sigs.k8s.io/kustomize/[email protected]/openapi/openapi.go:656:33: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to swagger.FromGnostic

Looks like github.com/google/gnostic conflicting to github.com/google/gnostic-models.

@koba1t
Copy link
Member Author

koba1t commented Jun 6, 2023

I understand what happens on tests.
I think gnostic dependencies are already updated at master. #5186
But, the New kyaml tag is not released yet, and the e2econtainer test had dependencies for old kyaml that are not updated gnostic dependencies.

I think I was finished fixing that failing test.

Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit da31b96 into kubernetes-sigs:master Jun 7, 2023
@koba1t koba1t deleted the update_go_1.20 branch June 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants