New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove setters from kyaml #5291

Merged

k8s-ci-robot merged 1 commit into kubernetes-sigs:master from irvifa:refactor/remove-setters-config-from-kyaml

Sep 8, 2023

Commits on Aug 23, 2023

refactor: Remove setters from kyaml

Kind:

Refactor

Summary:

Setters functionality is provided as a KRM function. We should remove code related to setters in cmd/config and kyaml.
As of now most setters2 and setters usage are related to fork of kpt, however, these:
[fluxcd/image-automation-controller](https://github.com/fluxcd/image-automation-controller/blob/6827808a1aa8c31ae0c05366db8e90c011f6ebd2/pkg/update/filter.go#L24) with [kyml](https://github.com/fluxcd/image-automation-controller/blob/6827808a1aa8c31ae0c05366db8e90c011f6ebd2/go.mod#L42)
[rancher/fleet](https://github.com/rancher/fleet/blob/0a6cf6cb9278d00e743e79ed1884b19e1bc6ec74/internal/cmd/controller/controllers/image/update/setters.go#L16) with [kyaml](https://github.com/rancher/fleet/blob/0a6cf6cb9278d00e743e79ed1884b19e1bc6ec74/go.mod#L75)

Repositories still using them, They pinned these two into a specific kyaml version. If we decide to go for this removal then we can make a release note that this is actually removed on the next version since we already marked this as deprecated before.

irvifa committed Aug 23, 2023