-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to kubernetes 1.26.5 #1265
Update dependencies to kubernetes 1.26.5 #1265
Conversation
Signed-off-by: Davanum Srinivas <[email protected]>
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @serathius |
/assign @s-urbaniak |
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
d0153f8
to
91f40b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @serathius @dgrisonnet
This needs to be discussed. Do we need to discard the log flags now?
The reason is the legacy klog flags are no longer available from Kubernetes v1.26. See kubernetes/kubernetes#112120 for more details. We might need to record the changes somewhere like a release note about the flag changes. /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@serathius is there a plan to cut a new release? |
Need a new version of metrics-server with newer dependencies with k8s 1.26.5
What i actually need is here:
kubernetes-sigs/prometheus-adapter#574 (comment)
But to get there i need a newer version of metrics-server released that has kubernetes 1.26.4 or above, hence updated to 1.26.5
Fixes #1260