Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to kubernetes 1.26.5 #1265

Conversation

dims
Copy link
Member

@dims dims commented May 30, 2023

Need a new version of metrics-server with newer dependencies with k8s 1.26.5

What i actually need is here:
kubernetes-sigs/prometheus-adapter#574 (comment)

But to get there i need a newer version of metrics-server released that has kubernetes 1.26.4 or above, hence updated to 1.26.5

Fixes #1260

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2023
@dims
Copy link
Member Author

dims commented May 30, 2023

/assign @serathius

@dims
Copy link
Member Author

dims commented May 30, 2023

/assign @s-urbaniak

dims added 4 commits May 30, 2023 18:12
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the update-dependencies-to-kubernetes-1.26.5 branch from d0153f8 to 91f40b3 Compare May 30, 2023 22:12
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @serathius @dgrisonnet
This needs to be discussed. Do we need to discard the log flags now?

@RainbowMango
Copy link
Member

This needs to be discussed. Do we need to discard the log flags now?

The reason is the legacy klog flags are no longer available from Kubernetes v1.26. See kubernetes/kubernetes#112120 for more details.

We might need to record the changes somewhere like a release note about the flag changes.

/lgtm
Good Job @dims ! It's exactly what I expected.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 72766ce into kubernetes-sigs:master May 31, 2023
@RainbowMango
Copy link
Member

@serathius is there a plan to cut a new release?

@serathius
Copy link
Contributor

#1165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] (already the newest version) does not compatible with k8s.io/[email protected]
6 participants