Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow tag-less promotions (promote images without tagging them) #114

Closed
listx opened this issue Aug 27, 2019 · 1 comment
Closed

allow tag-less promotions (promote images without tagging them) #114

listx opened this issue Aug 27, 2019 · 1 comment
Assignees

Comments

@listx
Copy link
Contributor

listx commented Aug 27, 2019

Today the promoter will only promote those images that have tags in them. This feature will allow images to be promoted even if they don't have tags.

We could easily shell out to https://github.com/google/go-containerregistry/tree/master/cmd/gcrane#cp instead of the usual "gcloud container add-tag" command we use; the only annoying part here is that we would have to ship the gcrane binaries from the offiical gcr.io/go-containerregistry/gcrane path, but it should be doable. Alternatively, we could drop our reliance on gcloud container add-tag altogether and just lift the code already in gcrane to use the underlying API calls to GCR (we already import the go-containerregistry library that gcrane uses for other parts of our codebase). This latter approach is the better but obviously it might take more engineering effort.

This issue is a blocker for creating the backfilled promoter manifest for gcr.io/google-containers. That is, we want to have a (large) promoter manifest for all images in gcr.io/google-containers.

We already support the -snapshot flag which allows for snapshotting a registry (all images, including both tagged and tagless images); so this feature would allow for promotions of said snapshots as-is.

@listx
Copy link
Contributor Author

listx commented Aug 30, 2019

Cross-reference links: #70 #118

@listx listx closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant