Tagless promotions #118
Merged
Tagless promotions #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
|
From the e2e test it appears that gcr.io/k8s-staging-cip-test/golden-foo/foo@sha256:03aec0c717de7850ee3e3165ecdf73cf1abf0bdb5b6cce04695eeb80637360f8 is the digest of the tagless image, and not 427db5df9ceef52fcb600ed929fe6523566276d2bd81fa066a5cf0ffd9d74278 as predicted from local testing. I'm going to re-run the e2e test and see if it changes anything (if that hash changes again). /test pull-cip-e2e |
listx
force-pushed
the
tagless-promotions
branch
2 times, most recently
from
204d0ac
to
395b087
Compare
listx
force-pushed
the
tagless-promotions
branch
from
395b087
to
38c095e
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
listx
force-pushed
the
tagless-promotions
branch
from
38c095e
to
0615350
Compare
|
/assign @justinsb |
|
/assign @ps882 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @listx /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, listx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
added 2 commits
September 13, 2019 12:38
This way we open up the path to promoting images without needing to tag them. This also probably helps with performance as we don't need to shell out to create a new process for every image promotion.
Also tweak the unit test and e2e tests to make sure we can promote images that don't have tags.
listx
force-pushed
the
tagless-promotions
branch
from
0615350
to
c608b17
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the e2e test passes then this PR will supersede #115.
/hold