make logging more verbose #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we can still see the same errors from the Cloud Run dashboard (instead of being forced to look into the Stackdriver logs), because Cloud Run by default only shows STDERR/STDOUT logs.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/release
|
/lgtm |
k8s-ci-robot
added
the
lgtm
listx
pushed a commit
to listx/k8s.io
that referenced
this pull request
Mar 30, 2020
This version includes a cip-auditor version with fixes to logging [1] and also child digest image detection [2]. [1]: kubernetes-sigs/promo-tools#206 [2]: kubernetes-sigs/promo-tools#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we can still see the same errors from the Cloud
Run dashboard (instead of being forced to look into the Stackdriver
logs), because Cloud Run by default only shows STDERR/STDOUT logs.
This addresses #183