Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --verbose flag to auditor builds #367

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

tylerferrara
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change enables the verbosity feature for auditor builds. By passing the --verbose flag, additional debug statements are logged to show the state changes within image audits. Additionally, this feature enables request counters to track the number of HTTP requests made to GCR. This provides additional visibility into the network usage of the auditor, and gives a rough estimate of how close to the actual GCR quota this service is getting.

Which issue(s) this PR fixes:

Related k8s.io noisy audit alers: #2364
Part of #259 #353

Special notes for your reviewer:

Once deployed to Cloud Run, every 10min the logs should report a debug statement like this:
From 2021-07-26 15:00:0 to 2021-07-26 15:10:00 [10 min] there have been 1429 requests to GCR.

Does this PR introduce a user-facing change?

YES
Logs will now report audit state changes & GCR usage.

Enabled verbose logging feature to auditor builds.

cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2021
@tylerferrara
Copy link
Contributor Author

/assign @listx

@listx
Copy link
Contributor

listx commented Jul 26, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: listx, tylerferrara

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@tylerferrara
Copy link
Contributor Author

Logs show:
This may be due to network connectivity issues. Please check your network settings, and the status of the service you are trying to reach.
/test pull-cip-auditor-e2e

@tylerferrara tylerferrara mentioned this pull request Jul 26, 2021
9 tasks
@k8s-ci-robot k8s-ci-robot merged commit e283fb6 into kubernetes-sigs:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants