Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/prometheus/common module #200

Conversation

danilo-gemoli
Copy link
Contributor

@danilo-gemoli danilo-gemoli commented Jun 27, 2024

As per title, update the prometheus/common module:

go get github.com/prometheus/[email protected]

What follow is the sole breaking change I have hit.
The field:

expfmt.FmtProtoDelim

is no longer public and it has been replaced by this function:

expfmt.NewFormat(expfmt.TypeProtoDelim)

They both result in the same string:

fmtProtoDelim        Format = protoFmt + ` encoding=delimited`

so we should be safe.

Check prometheus/common#576 for more information.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 2f31c50
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/667d1d06e233af0008f188db
😎 Deploy Preview https://deploy-preview-200--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danilo-gemoli
Copy link
Contributor Author

/retest-required

@danilo-gemoli
Copy link
Contributor Author

We are running out of resources:

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/46 nodes are available: 3 node(s) had untolerated taint {node-group: stable}, 43 Insufficient cpu. preemption: 0/46 nodes are available: 3 Preemption is not helpful for scheduling, 43 No preemption victims found for incoming pod..)

@danilo-gemoli
Copy link
Contributor Author

/retest-required

@droslean
Copy link
Contributor

/retest

@droslean
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 79d27b6 into kubernetes-sigs:main Jun 27, 2024
11 checks passed
@danilo-gemoli danilo-gemoli deleted the chore/update-prometheus-common branch June 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants