Enable magnum provider scale to zero #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now supported by magnum. https://review.opendev.org/c/openstack/magnum/+/737580/ If using node group autodiscovery, older versions of magnum will still forbid scaling to zero or setting the minimum node count to zero.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, tghartland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gtirloni
added a commit
to gtirloni/vexxhost-magnum-cluster-api
that referenced
this pull request
Jul 15, 2024
The current behavior sets min_node_count to 1 if the user specifies it should be zero. Zero is supported by both Magnum and the Cluster Autoscaler. This sets it to the default value 1 (same as Magnum when min_node_count is not specified) only when it was not specified. Related: * Magnum: https://review.opendev.org/c/openstack/magnum/+/737580 * Autoscaler: kubernetes/autoscaler#3995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3928
Now supported by magnum.
https://review.opendev.org/c/openstack/magnum/+/737580/
If using node group autodiscovery, older versions
of magnum will still forbid scaling to zero or
setting the minimum node count to zero.