Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about usage of batch processing for check capacity in FAQ #7282

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add information about usage of batch processing for check capacity in FAQ #7282

merged 1 commit into from
Nov 8, 2024
+32 −0

Conversation

Duke0404
Copy link
Contributor

@Duke0404 Duke0404 commented Sep 13, 2024 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds information about usage of batch processing for check capacity in FAQ

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

cc: @aleksandra-malinowska @kawych

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Duke0404. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
Shubham82
Shubham82 suggested changes Sep 17, 2024
View reviewed changes
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@Shubham82
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2024
@Shubham82
Copy link
Contributor

Thanks, @Duke0404 for this PR.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2024
@Shubham82
Copy link
Contributor

@Duke0404, please resolve the merge conflict.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2024
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@Shubham82
Copy link
Contributor

cc @aleksandra-malinowska
Need your approval to merge this PR.

Thanks!

@Shubham82
Copy link
Contributor

cc @x13n
PTAL!

aleksandra-malinowska
aleksandra-malinowska reviewed Nov 5, 2024
View reviewed changes
cluster-autoscaler/FAQ.md Outdated
4. **Batch Timebox**: Set the maximum time in seconds that Cluster Autoscaler will
spend processing CheckCapacity ProvisioningRequests in a single iteration by
setting the following flag in your Cluster Autoscaler configuration:
`--batch-timebox=<timebox>`. The default value is 5m.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the default changed to 10s in final version, can you please update this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this in the code and it is 10s.

I missed it, thanks @aleksandra-malinowska

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
aleksandra-malinowska
aleksandra-malinowska reviewed Nov 8, 2024
View reviewed changes
cluster-autoscaler/FAQ.md Outdated

#### Enabling Batch Processing

1. **Cluster Autoscaler Version**: Ensure you are using Cluster Autoscaler version 1.31.1 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.31.1 implies it's going be cherry-picked to 1.31 - I don't think this is likely to happen. We generally don't backport features, only bug-fixes.

I think the first version to have this will be 1.32.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

aleksandra-malinowska
aleksandra-malinowska reviewed Nov 8, 2024
View reviewed changes
cluster-autoscaler/FAQ.md

2. **Feature Flag**: Enable batch processing mode by setting the following flag in your
Cluster Autoscaler configuration:
`--check-capacity-batch-processing=true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, batch processing is disabled by default. Specified in the file.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@aleksandra-malinowska
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, Duke0404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8c71ebf into kubernetes:master Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubham82 Shubham82 Shubham82 requested changes

@aleksandra-malinowska aleksandra-malinowska aleksandra-malinowska left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

Assignees

@aleksandra-malinowska aleksandra-malinowska

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Duke0404 @k8s-ci-robot @Shubham82 @aleksandra-malinowska