Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled not working on NLB #168

Closed
luisamador opened this issue Jan 21, 2021 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@luisamador
Copy link

luisamador commented Jan 21, 2021

What happened:
service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
The annotation above doesn't take any effect on NLBs. It doesn't matter if you are updating an existing NLB or if you are provisioning it from scratch.

What you expected to happen:
The "Cross-zone load balancing" setting enabled on the NLB.

How to reproduce it (as minimally and precisely as possible):
Just create a K8s Service resource with the following annotations:

service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
service.beta.kubernetes.io/aws-load-balancer-internal: "true"
service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"

Environment:
both Kubectl and AWS EKS cluster on version v1.18.9

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2021
@mars64
Copy link

mars64 commented Feb 3, 2021

I think you're looking for the aws-load-balancer-controller project -- they just took over for the Ticketmaster/CoreOS ALB Ingress Controller and I think are the ones that provide the annotation you reference.

[edit]: I can at least confirm that service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true" appears to work properly via aws-load-balancer-controller

[edit x 2]: derp I was using an nlb-ip. My test is invalid, they don't provide for nlb yet.

In any case, behold:

What I take from this is:

  • legacy provider will be fixed in 1.20
  • go-forward provider (i.e. aws-load-balancer-controller) still figuring out how to take this over from in-tree

@kishorj
Copy link
Contributor

kishorj commented Feb 8, 2021

Legacy cloud provider has the fix kubernetes/kubernetes#95247, and will be available in 1.20.

@nckturner
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@nckturner: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants