Allow user to specify Registry Pull Secret

[apt-x4869]

What type of PR is this? /kind feature

What this PR does / why we need it:
Requirement is to specify credentials for pulling image from private registry.

Which issue(s) this PR fixes:
Allows user to specify imagepullsecret
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

release-note:

Allow user to specify imagePullSecrets 

[k8s-ci-robot]

Hi @apt-x4869. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[apt-x4869]

/kind feature

[apt-x4869]

@cartermckinnon @dims ,
Could you review ?

[dims]

@apt-x4869 dunno which way we will go #933

Do you mind adding what your use case is in that issue?

[apt-x4869]

@apt-x4869 dunno which way we will go #933

Do you mind adding what your use case is in that issue?

@dims
Added use case.

[apt-x4869]

@cartermckinnon @dims ,
Could you review ?

[apt-x4869]

Hello
Any remarks?

[apt-x4869]

Hello @cartermckinnon @dims

Could I have a review ?

Thanks,
Aman

[apt-x4869]

@cartermckinnon @dims ,
Could you please review ?
Sadly, it has been two months now for this simple change.

[dims]

/assign @cartermckinnon @kmala

[kmala]

since there are use cases mentioned in #933 , we can pick the new changes to the helm template for now. Sorry for the delay @apt-x4869
/ok-to-test

[kmala]

/triage accepted

[apt-x4869]

/retest

[apt-x4869]

@kmala
Needs approved, lgtm labels.

[kmala]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kmala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment