don't process unsupported loadbalancers with mixed protocols

[aojea]

The external cloud provider controller for loadbalancers does not support Services with different protocols and most probably it will never support them, since most of the functionality and development for loadbalancers is being done in the ingress-gce project.

Current code assumes that is not possible to have multiple protocols in multiple places

cloud-provider-gcp/providers/gce/gce_loadbalancer_external.go

Lines 1043 to 1050 in a874896

	// TODO: Make this more generic. Currently this method is only
	// used to create firewall rules for loadbalancers, which have
	// exactly one protocol, so we can never end up with a list of
	// mixed TCP and UDP ports. It should be possible to use a
	// single firewall rule for both a TCP and UDP lb.
	IPProtocol: strings.ToLower(string(ports[0].Protocol)),
	Ports: portRanges,
	},

cloud-provider-gcp/providers/gce/gce_loadbalancer_internal.go

Lines 857 to 858 in a874896

	// GCP doesn't support multiple protocols for a single load balancer
	protocol = svcPorts[0].Protocol

Code borrowed from the cloud-provider-aws, thanks

Ref: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1435-mixed-protocol-lb
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• providers/gce/OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

/assign @cezarygerard @bowei @thockin

[aojea]

/hold

wait for kubernetes/kubernetes#115966 to sync both patches

[aojea]

/assign @andrewsykim

[aojea]

kubernetes/kubernetes#115966 already merged
/unhold

/assign @jprzychodzen

[aojea]

@cezarygerard we need to get this merge to avoid confusion on users

[sftim]

(Thanks for the PR)

[k8s-ci-robot]

@aojea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-gcp-scenario-kops-simple	56834cc	link	false	/test pull-cloud-provider-gcp-scenario-kops-simple

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aojea]

@cezarygerard please review again and lgtm once you are ok

[cezarygerard]

/lgtm