Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link checker for this repo #359

Closed
pmorie opened this issue Feb 11, 2017 · 36 comments
Closed

Add a link checker for this repo #359

pmorie opened this issue Feb 11, 2017 · 36 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Milestone
August

Comments

@pmorie
Copy link
Member

pmorie commented Feb 11, 2017

While looking at the API conventions docs this morning, I found that many of the links in that doc were broken. We should add a link checker for this repo (and eventually other repos in the community).
This was referenced Feb 11, 2017
Merged
Closed
@pmorie
Copy link
Member Author

pmorie commented Feb 11, 2017

@duglin any chance you might be interested in doing this?

@chupman
Copy link

chupman commented Mar 13, 2017

I'd like to work on this. I've looked at verify-links.sh script that @duglin wrote, but I'm not totally clear on how you want the link checking implemented. Are you wanting something like a scheduled task to regularly scan for dead links? Or just something to manually run from time to time?

@duglin
Copy link

duglin commented Mar 13, 2017

@chupman it should run as part of the verification checks that are part of the normal kube build process. So basically it should run on every PR. Similar to what is done for lint and gofmt checks.

@chupman
Copy link

chupman commented Mar 14, 2017

I'm most likely overthinking it, but my concern was that if you run on every PR it could cause unrelated errors if an existing link goes dead. Would it make sense to expect an extra arg with the files changed in addition to the repo base dir? Or is it better to just leave it simple and just scan the whole repo and let the reviewer read the error log?

@duglin
Copy link

duglin commented Mar 14, 2017

The purpose behind running the test is exact what you said... to find dead links. So we want things to fail if there area dead links. I suspect the first time we turn this on we'll find a TON and it'll result in the PR to add this to also include a ton of md file fixes. :-)

Now if you're concerned about having to check too many files and it being slow, we should wrapper the call to the checker with code that only calls it for files changed in the current PR/commit.

@duglin
Copy link

duglin commented Mar 16, 2017

For reference, here the repo with the link checker: https://github.com/duglin/vlinker

@jamiehannaford
Copy link
Contributor

If nobody else is already working on this, I'd like to help out.

@duglin are there any docs about how to set up CI on a new repo? I'm not sure what the conventions are - e.g. is it okay to use Travis or does everything need to go through the existing https://github.com/kubernetes/test-infra?

@jamiehannaford
Copy link
Contributor

Also, instead of writing a new script, perhaps we could use or refactor https://github.com/kubernetes/kubernetes/blob/master/cmd/mungedocs/links.go and run all the mung scripts on a PR?

@chupman
Copy link

chupman commented Apr 20, 2017

I'm currently waiting on code review from @duglin for some enhancements on his link checker. Despite the fact that I've already invested some time in this I agree that if there's something out there that's already maintained it's probably a better option. In case we do go with vlinker I'd also like to know about the CI integration. I was using travis on my own forks for testing while I was whittling down false positives.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2017
@cblecker cblecker added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2017
@nikhita nikhita mentioned this issue Oct 6, 2017
Closed
porridge pushed a commit to porridge/community that referenced this issue Oct 17, 2017
Fix name and link to k8s oncall.
337f80a 
https://github.com/k8s-oncall works
https://github.com/search?q=k8s-support-oncall&type=Users&utf8=%E2%9C%93
shows no matches, and https://github.com/k8s-support-oncall is a 404.

I guess this is another call for kubernetes#359.
@porridge porridge mentioned this issue Oct 17, 2017
Merged
erinboyd pushed a commit to erinboyd/community that referenced this issue Oct 23, 2017
Fix name and link to k8s oncall.
f3dc6e2 
https://github.com/k8s-oncall works
https://github.com/search?q=k8s-support-oncall&type=Users&utf8=%E2%9C%93
shows no matches, and https://github.com/k8s-support-oncall is a 404.

I guess this is another call for kubernetes#359.
erinboyd pushed a commit to erinboyd/community that referenced this issue Oct 23, 2017
Fix name and link to k8s oncall.
aac461b 
https://github.com/k8s-oncall works
https://github.com/search?q=k8s-support-oncall&type=Users&utf8=%E2%9C%93
shows no matches, and https://github.com/k8s-support-oncall is a 404.

I guess this is another call for kubernetes#359.
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2018
@cblecker
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2018
@jamiehannaford
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Mar 20, 2019
@nikhita
Copy link
Member

nikhita commented Mar 20, 2019

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 20, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Jun 18, 2019
@nikhita
Copy link
Member

nikhita commented Jun 18, 2019 via email

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2019
@spiffxp
Copy link
Member

spiffxp commented Jun 26, 2019

/assign
As I'm helping review PR from @chupman

@spiffxp spiffxp added this to the August milestone Jun 26, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 26, 2019

/unassign
/help
@chupman wasn't able to complete #3324

@k8s-ci-robot
Copy link
Contributor

@spiffxp:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/unassign
/help
@chupman wasn't able to complete #3324

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 26, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 23, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@llhuii llhuii mentioned this issue Aug 3, 2021
Open
@MadhavJivrajani MadhavJivrajani mentioned this issue Aug 29, 2021
Closed
danehans pushed a commit to danehans/community that referenced this issue Jul 18, 2023
@rshriram
update list of members in early disclosure list (kubernetes#359)
c43a6e2 
* Remove list of members in early disclosure list

This list is very much outdated. We can't keep updating this as more people join the list.

* update again with member companies

* Update EARLY-DISCLOSURE.md
liubin pushed a commit to liubin/community that referenced this issue Oct 16, 2023
election: 2023-10 Add Fupan Li candidacy
e7ea4c3 
Add my candidacy for the October 2023 cycle.

Fixes: kubernetes#359

Signed-off-by: Fupan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
August
Development

Successfully merging a pull request may close this issue.

Added dependancies and wrapper script for linkchecker chupman/community