Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document what qualifies for a milestone bug triage #4628

Closed
wants to merge 2 commits into from
Closed

Document what qualifies for a milestone bug triage #4628

wants to merge 2 commits into from

Conversation

onlydole
Copy link
Member

Per the v1.18 Kubernetes release objectives, this will help document what qualifies for a milestone when cherry-picking.

Fixes kubernetes/sig-release#320

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 17, 2020
@onlydole
Copy link
Member Author

/assign @markyjackson-taulia
/assign @alejandrox1
/assign @mrbobbytables

markjacksonfishing
markjacksonfishing approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markyjackson-taulia, onlydole
To complete the pull request process, please assign mrbobbytables
You can assign the PR to them by writing /assign @mrbobbytables in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onlydole
Copy link
Member Author

Closing this PR for now (will revisit later)
/close

@k8s-ci-robot
Copy link
Contributor

@onlydole: Closed this PR.

In response to this:

Closing this PR for now (will revisit later)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@mrbobbytables mrbobbytables

@alejandrox1 alejandrox1

@markjacksonfishing markjacksonfishing

Labels
area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add information about what qualifies for a milestone
5 participants
@onlydole @k8s-ci-robot @markjacksonfishing @mrbobbytables @alejandrox1