Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAPI v1.9 release team members #8049

Conversation

Sunnatillo
Copy link
Contributor

@Sunnatillo Sunnatillo commented Aug 26, 2024

New CAPI v1.9 RT members announced here: https://kubernetes.slack.com/archives/C8TSNPY4T/p1723216277709389

This PR removes old and adds new v1.9 RT members from/to the list in alphabetical order.

Part of kubernetes-sigs/cluster-api#11092

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Sunnatillo!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Sunnatillo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Aug 26, 2024
@cahillsf
Copy link
Member

many of these users don't appear to be mapped in users.yaml. you will need to update the list to map their GH IDs to their slack user IDs: #7645

@Sunnatillo Sunnatillo force-pushed the update-capi-v1.9-release-team-members branch from f7de682 to 90e35f5 Compare August 27, 2024 20:07
@Sunnatillo
Copy link
Contributor Author

many of these users don't appear to be mapped in users.yaml. you will need to update the list to map their GH IDs to their slack user IDs: #7645

Thank your for the review.
Added users to user.yaml file.

@Sunnatillo
Copy link
Contributor Author

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2024
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@Sunnatillo
Copy link
Contributor Author

@jeefy @mrbobbytables
Could we merge this please?

@Sunnatillo
Copy link
Contributor Author

@alejandrox1 @coderanger @munnerz @DylanGraham @jberkus
Could we merge this please?

@fabriziopandini
Copy link
Member

cc @MadhavJivrajani @palnabarun if you have some spare time

@jberkus
Copy link
Contributor

jberkus commented Sep 12, 2024

/approve

In the future, can ClusterAPI have a file somewhere in your repo with the release team members? Slack messages are emphemeral.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit b519cd5 into kubernetes:master Sep 12, 2024
3 checks passed
@sbueringer
Copy link
Member

/approve

In the future, can ClusterAPI have a file somewhere in your repo with the release team members? Slack messages are emphemeral.

Not sure if I have full context, we have the list here https://github.com/kubernetes-sigs/cluster-api/blob/main/OWNERS_ALIASES#L120

@sbueringer
Copy link
Member

@Sunnatillo Sunnatillo deleted the update-capi-v1.9-release-team-members branch September 16, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants